Make SkBlurImageFilter capable of cropping during blur (GPU path).

Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and
right rects, blur without bounds checks in middle rect.

Note: this change causes minor pixels diffs in the 
imagefilterscropexpand GM: for odd crop positions relative to the
dstBounds, we are now correctly resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
Committed: https://skia.googlesource.com/skia/+/c57e0ded7d535523cfc6bf07c78e5f3479bb8c42

Committed: https://skia.googlesource.com/skia/+/07d56b13927a4cb8dc4db16c8a573dee120937f1

[Stephen White, 2015-11-05 17:56:47]

Description was changed from

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

BUG=skia:4502, skia:4526
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and right
rects, blur without bounds checks in middle rect.

Note that this change causes minor pixels diffs in the imagefilterscropexpand
GM: for odd crop positions relative to the dstBounds, we are now correctly
resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[Stephen White, 2015-11-05 17:56:47]

senorblanco@chromium.org changed reviewers:
+ bsalomon@google.com

[Stephen White, 2015-11-05 17:57:02]

Description was changed from

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and right
rects, blur without bounds checks in middle rect.

Note that this change causes minor pixels diffs in the imagefilterscropexpand
GM: for odd crop positions relative to the dstBounds, we are now correctly
resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and right
rects, blur without bounds checks in middle rect.

Note that this change causes minor pixels diffs in the imagefilterscropexpand
GM: for odd crop positions relative to the dstBounds, we are now correctly
resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
==========

[Stephen White, 2015-11-05 17:57:11]

Brian: PTAL. Thanks!

[Stephen White, 2015-11-05 18:03:54]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 18:04:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431593002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431593002/180001

[commit-bot: I haz the power, 2015-11-05 18:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 18:06:18]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2015-11-05 21:25:03]

lgtm

[Stephen White, 2015-11-05 22:05:35]

Description was changed from

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and right
rects, blur without bounds checks in middle rect.

Note that this change causes minor pixels diffs in the imagefilterscropexpand
GM: for odd crop positions relative to the dstBounds, we are now correctly
resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
==========

to

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and right
rects, blur without bounds checks in middle rect.

Note that this change causes minor pixels diffs in the imagefilterscropexpand
GM: for odd crop positions relative to the dstBounds, we are now correctly
resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
==========

[Stephen White, 2015-11-05 22:06:07]

Description was changed from

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and right
rects, blur without bounds checks in middle rect.

Note that this change causes minor pixels diffs in the imagefilterscropexpand
GM: for odd crop positions relative to the dstBounds, we are now correctly
resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
==========

to

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and
right rects, blur without bounds checks in middle rect.

Note: this change causes minor pixels diffs in the 
imagefilterscropexpand GM: for odd crop positions relative to the
dstBounds, we are now correctly resampling at an even pixel boundary.

BUG=skia:4502, skia:4526
==========

[Stephen White, 2015-11-05 22:18:05]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 22:18:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431593002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431593002/200001

[Stephen White, 2015-11-05 22:22:36]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 22:22:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431593002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431593002/220001

[Stephen White, 2015-11-05 22:37:55]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-11-05 22:37:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1431593002/#ps260001
(title: "Tweak comment")

[commit-bot: I haz the power, 2015-11-05 22:38:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431593002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431593002/260001

[commit-bot: I haz the power, 2015-11-05 22:48:47]

Committed patchset #15 (id:260001) as
https://skia.googlesource.com/skia/+/c57e0ded7d535523cfc6bf07c78e5f3479bb8c42

[egdaniel, 2015-11-09 18:04:05]

A revert of this CL (patchset #15 id:260001) has been created in
https://codereview.chromium.org/1407133019/ by egdaniel@google.com.

The reason for reverting is: Causing valgrind error. Looks like the issue is in
conolve_gaussiand_2d where bounds is not getting set if there is no srcBounds,
but later on that bounds is being read in the creation of a TextureDomain..

[Stephen White, 2015-11-10 15:16:45]

Description was changed from

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and
right rects, blur without bounds checks in middle rect.

Note: this change causes minor pixels diffs in the 
imagefilterscropexpand GM: for odd crop positions relative to the
dstBounds, we are now correctly resampling at an even pixel boundary.

BUG=skia:4502, skia:4526

Committed:
https://skia.googlesource.com/skia/+/c57e0ded7d535523cfc6bf07c78e5f3479bb8c42
==========

to

==========
Make SkBlurImageFilter capable of cropping during blur (GPU path).

This is the GPU equivalent of https://codereview.chromium.org/1415653003/.

It requires passing down the bounds of the crop rect (srcBounds), and 
turning the blur 3-patch optimization in convolve_gaussian() into a 5-patch:
clear above and below srcBounds, blur with bounds checks inside left and
right rects, blur without bounds checks in middle rect.

Note: this change causes minor pixels diffs in the 
imagefilterscropexpand GM: for odd crop positions relative to the
dstBounds, we are now correctly resampling at an even pixel boundary.

BUG=skia:4502, skia:4526

Committed:
https://skia.googlesource.com/skia/+/c57e0ded7d535523cfc6bf07c78e5f3479bb8c42
==========

[Stephen White, 2015-11-10 15:17:54]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-10 15:18:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431593002/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431593002/270001

[commit-bot: I haz the power, 2015-11-10 15:30:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 15:30:22]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2015-11-10 15:31:53]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-11-10 15:31:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1431593002/#ps270001
(title: "Fix uninitialized bounds in convolve_gaussian_2d()")

[commit-bot: I haz the power, 2015-11-10 15:32:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431593002/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431593002/270001

[commit-bot: I haz the power, 2015-11-10 15:32:43]

Committed patchset #16 (id:270001) as
https://skia.googlesource.com/skia/+/07d56b13927a4cb8dc4db16c8a573dee120937f1