Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pdfium.gyp

Issue 1431563002: chromium_code tweaks for Windows and Linux/gyp. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index 878879484811963ba4708633651df2b961377b86..f4eabc1c8807838a73cdc4994b014793fa27b6eb 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -41,13 +41,17 @@
}],
],
'msvs_disabled_warnings': [
- 4005, 4018, 4146, 4333, 4345, 4267
+ 4005, 4018, 4146, 4333, 4345, 4267,
+ # TODO(thestig): Fix all instances, remove this, pdfium:29
+ 4245, 4389, 4701, 4706, 4800,
],
'variables': {
'clang_warning_flags': [
# TODO(thestig): Fix all instances, remove this, pdfium:29
'-Wno-sign-compare',
],
+ # Make sure build/common.gypi doesn't re-add the flag on linux.
Lei Zhang 2015/10/30 18:57:32 "Make sure Chromium's build/common.gypi"
Nico 2015/10/30 19:09:31 (done, btw)
+ 'cflags_cc!': [ '-Wsign-compare' ],
},
},
'targets': [
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698