Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 1431563002: chromium_code tweaks for Windows and Linux/gyp. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdfium.gyp » ('j') | pdfium.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index fa6c90653f95916e993029dcc6cc50ba593d1646..3e1b89c366b0d70f3859d0d56209cf707c5c8d84 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -38,6 +38,12 @@ config("pdfium_config") {
"/wd4146",
"/wd4333",
"/wd4345",
+ # TODO(thestig): Fix all instances, remove this, pdfium:29
+ "/wd4245",
+ "/wd4389",
+ "/wd4701",
+ "/wd4706",
+ "/wd4800",
]
}
« no previous file with comments | « no previous file | pdfium.gyp » ('j') | pdfium.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698