specify the reason for blacklisting

specify the reason for blacklisting

BUG=482259
Committed: https://crrev.com/dca5d7a23fee0d57298e192921da79c814833296
Cr-Commit-Position: refs/heads/master@{#356731}

[bpastene, 2015-10-28 17:40:24]

Description was changed from

==========
specify the reason for blacklisting

BUG=
==========

to

==========
specify the reason for blacklisting

BUG=482259
==========

[bpastene, 2015-10-28 17:42:24]

bpastene@chromium.org changed reviewers:
+ jbudorick@chromium.org

[bpastene, 2015-10-28 17:42:24]

ptal

Are the reasons accurate for each case?
Did I miss any other places where a device can get blacklisted?

[jbudorick, 2015-10-28 21:13:27]

On 2015/10/28 17:42:24, bpastene wrote:
> ptal
> 
> Are the reasons accurate for each case?
> Did I miss any other places where a device can get blacklisted?

You missed one, which is currently only called on a failure while listing tests
on a device:
https://code.google.com/p/chromium/codesearch#search/&q=BlacklistDevice%20cas...

[bpastene, 2015-10-28 22:44:47]

On 2015/10/28 21:13:27, jbudorick wrote:
> On 2015/10/28 17:42:24, bpastene wrote:
> > ptal
> > 
> > Are the reasons accurate for each case?
> > Did I miss any other places where a device can get blacklisted?
> 
> You missed one, which is currently only called on a failure while listing
tests
> on a device:
>
https://code.google.com/p/chromium/codesearch#search/&q=BlacklistDevice%20cas...

This one wasn't as straightforward; had to change the decorator. The reason
would be the name of the function that it decorates.

Let me know what you think

[jbudorick, 2015-10-28 23:34:05]

lgtm w/ nit

https://codereview.chromium.org/1430663002/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_test_run.py (right):

https://codereview.chromium.org/1430663002/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_test_run.py:32: f: the function
being decorated. The function must take at least one
nit: update this now that the function must take at least two arguments

[bpastene, 2015-10-28 23:41:57]

https://codereview.chromium.org/1430663002/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_test_run.py (right):

https://codereview.chromium.org/1430663002/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_test_run.py:32: f: the function
being decorated. The function must take at least one
On 2015/10/28 23:34:05, jbudorick wrote:
> nit: update this now that the function must take at least two arguments

The decorated function doesn't change. The on_failure function does though
(hence the docstring change right below)

[jbudorick, 2015-10-28 23:45:15]

https://codereview.chromium.org/1430663002/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_test_run.py (right):

https://codereview.chromium.org/1430663002/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_test_run.py:32: f: the function
being decorated. The function must take at least one
On 2015/10/28 23:41:57, bpastene wrote:
> On 2015/10/28 23:34:05, jbudorick wrote:
> > nit: update this now that the function must take at least two arguments
> 
> The decorated function doesn't change. The on_failure function does though
> (hence the docstring change right below)

oh, right. derp.

[bpastene, 2015-10-28 23:59:47]

The CQ bit was checked by bpastene@chromium.org

[commit-bot: I haz the power, 2015-10-29 00:00:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1430663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1430663002/20001

[commit-bot: I haz the power, 2015-10-29 01:45:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-29 01:46:02]

Patchset 2 (id:??) landed as
https://crrev.com/dca5d7a23fee0d57298e192921da79c814833296
Cr-Commit-Position: refs/heads/master@{#356731}