Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: build/android/pylib/local/device/local_device_test_run.py

Issue 1430663002: specify the reason for blacklisting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add reason for local device failures Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/local/device/local_device_environment.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/local/device/local_device_test_run.py
diff --git a/build/android/pylib/local/device/local_device_test_run.py b/build/android/pylib/local/device/local_device_test_run.py
index 200ee4e41676d4519a1889da187bccbb90c6c0cc..2a93c68144cb7890b6440fd91a66d1b62c03808a 100644
--- a/build/android/pylib/local/device/local_device_test_run.py
+++ b/build/android/pylib/local/device/local_device_test_run.py
@@ -31,7 +31,7 @@ def handle_shard_failures_with(on_failure):
Args:
f: the function being decorated. The function must take at least one
jbudorick 2015/10/28 23:34:05 nit: update this now that the function must take a
bpastene 2015/10/28 23:41:57 The decorated function doesn't change. The on_fail
jbudorick 2015/10/28 23:45:15 oh, right. derp.
argument, and that argument must be the device.
- on_failure: A unary function to call on failure.
+ on_failure: A binary function to call on failure.
"""
def decorator(f):
@functools.wraps(f)
@@ -45,7 +45,7 @@ def handle_shard_failures_with(on_failure):
except device_errors.DeviceUnreachableError:
logging.exception('Shard died: %s(%s)', f.__name__, str(dev))
if on_failure:
- on_failure(dev)
+ on_failure(dev, f.__name__)
return None
return wrapper
« no previous file with comments | « build/android/pylib/local/device/local_device_environment.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698