build/android/adb_install_apk.py - Issue 1430663002: specify the reason for blacklisting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/adb_install_apk.py

Issue 1430663002: specify the reason for blacklisting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add reason for local device failures Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/adb_install_apk.py

diff --git a/build/android/adb_install_apk.py b/build/android/adb_install_apk.py

index 011509bb38eb6cb6848d1db4ce69cfd5fc932a83..a816bd403f8cc5c13d589728b10f20e3416b7d32 100755

--- a/build/android/adb_install_apk.py

+++ b/build/android/adb_install_apk.py

@@ -104,12 +104,12 @@ def main():

except device_errors.CommandFailedError:

logging.exception('Failed to install %s', args.apk_name)

if blacklist:

- blacklist.Extend([str(device)])

+ blacklist.Extend([str(device)], reason='install_failure')

logging.warning('Blacklisting %s', str(device))

except device_errors.CommandTimeoutError:

logging.exception('Timed out while installing %s', args.apk_name)

if blacklist:

- blacklist.Extend([str(device)])

+ blacklist.Extend([str(device)], reason='install_timeout')

logging.warning('Blacklisting %s', str(device))

device_utils.DeviceUtils.parallel(devices).pMap(blacklisting_install)