Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1430503007: Paint scrollbars at device scale resolution. (Closed)

Created:
5 years, 1 month ago by chrishtr
Modified:
5 years, 1 month ago
Reviewers:
ccameron
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kenneth.christiansen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Paint scrollbars at device scale resolution. BUG=531257 Committed: https://crrev.com/201cd54baaf4f94a76e7d254d70034c946168986 Cr-Commit-Position: refs/heads/master@{#358464}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 10 (3 generated)
chrishtr
5 years, 1 month ago (2015-11-06 23:11:09 UTC) #3
ccameron
lgtm https://codereview.chromium.org/1430503007/diff/1/third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp File third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp (right): https://codereview.chromium.org/1430503007/diff/1/third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp#newcode59 third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp:59: pictureBuilder.context().setDeviceScaleFactor(m_deviceScaleFactor); I have a vague preference for rolling ...
5 years, 1 month ago (2015-11-06 23:15:20 UTC) #4
chrishtr
On 2015/11/06 at 23:15:20, ccameron wrote: > lgtm > > https://codereview.chromium.org/1430503007/diff/1/third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp > File third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp (right): ...
5 years, 1 month ago (2015-11-06 23:22:06 UTC) #5
chrishtr
5 years, 1 month ago (2015-11-06 23:22:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430503007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430503007/1
5 years, 1 month ago (2015-11-06 23:22:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-07 00:16:46 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 00:17:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/201cd54baaf4f94a76e7d254d70034c946168986
Cr-Commit-Position: refs/heads/master@{#358464}

Powered by Google App Engine
This is Rietveld 408576698