Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2309593002: Factor code from ThemeMac into ThemeMacPainter. (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor code from ThemeMac into ThemeMacPainter. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/42dfffddb031acc75f772b57bd275795e0a6e814 Cr-Commit-Position: refs/heads/master@{#416660}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -238 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 1 2 2 chunks +1 line, -17 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.h View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 1 2 3 4 chunks +184 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ThemeMac.h View 2 chunks +18 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mac/ThemeMac.mm View 15 chunks +17 lines, -207 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (21 generated)
chrishtr
4 years, 3 months ago (2016-09-06 14:50:49 UTC) #20
Xianzhu
lgtm
4 years, 3 months ago (2016-09-06 16:00:19 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309593002/60001
4 years, 3 months ago (2016-09-06 16:00:42 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-06 17:54:10 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 17:56:50 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/42dfffddb031acc75f772b57bd275795e0a6e814
Cr-Commit-Position: refs/heads/master@{#416660}

Powered by Google App Engine
This is Rietveld 408576698