Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2536733003: Add tracing for LayoutView::commitPendingSelection (Closed)

Created:
4 years ago by chrishtr
Modified:
4 years ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tracing for LayoutView::commitPendingSelection Committing selection can sometimes be slow; see the attached bug for an example. BUG=668122 Committed: https://crrev.com/d160636f32a24e8fbe4a9d5569156972bfc3fdae Cr-Commit-Position: refs/heads/master@{#434671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
chrishtr
4 years ago (2016-11-28 16:02:47 UTC) #3
Stephen Chennney
LGTM, but could you add a sentence to the change description about why we're doing ...
4 years ago (2016-11-28 16:06:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536733003/1
4 years ago (2016-11-28 16:08:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 17:18:18 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 17:20:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d160636f32a24e8fbe4a9d5569156972bfc3fdae
Cr-Commit-Position: refs/heads/master@{#434671}

Powered by Google App Engine
This is Rietveld 408576698