|
Convert the remaining test_shell_tests to content_browsertests.
DomOperationsTests.*, DomSerializerTests.* and ResourceFetcherTests.* depended on TestShell loading URLs correctly. That couldn't be done with RenderViewTest harness since ResourceDispatcher code isn't hooked up. I added a mechanism for the browser test harness to run code on the renderer thread when running in --single-process mode. That way a "browser test" can poke at the renderer code. single-process mode doesn't work on Linux Aura, so disabled those tests there for now (bug 234172). DomSerializerTests.* fail on Android. They never ran there before since test_shell_tests never worked there, so just disabled them there with a note to investigate.
Note CppBoundClassTest is trivial and doesn't depend on loading, so I just made it a RenderViewTest.
I removed plugin_tests.cc:
-PluginTest.Refresh won't work with sharding. It's for a use case we don't care much about anyways, so a regression, if it happens, isn't critical.
-PluginTest.DeleteFrameDuringEvent is a duplicate of PluginTest.SelfDeletePluginInvokeInSynchronousMouseUp
-PluginTest.ForceReload is for in process plugins (i.e. test shell), doesn't apply to our multi-process plugins
-PluginTest.PluginVisibilty is currently disabled and failing. I thought about porting it and fixing it, but it seemed low priority since it'd be flaky to test this with our multi-process plugins. This code also doesn't change anymore, and if we had a regression we would catch this pretty quickly. If we regress we can write a test then.
mock_spellcheck_unittest.cc: was testing a mock object used in TestShell. Since TestShell is going away, there's no need for this test. if the object breaks and no existing tests break, then it's a non-issue.
memory_file_util.cc wasn't used other than in its unittest. I removed the code and its test.
CppBoundClassTest.* could be converted to a RenderViewTest. The remaining tests (HostVarTrackerTest.*, papiPluginInstanceTest.*, PpapiCustomInterfaceFactoryTest.*, QuotaFileIOTest.*, WebkitGlueUserAgentTest.* were converted to content_unittests.
I will delete the unused webkit/data in a follow up patch (try servers are failing on applying the delete).
BUG= 126514, 234172, 111601, 51622
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195701
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+1140 lines, -4572 lines) |
Patch |
|
M |
build/android/pylib/gtest/filter/content_browsertests_disabled
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_process_host_impl.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_process_host_impl.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
4 chunks |
+11 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/content_tests.gypi
|
View
|
1
2
3
4
5
6
7
8
9
10
|
8 chunks |
+28 lines, -1 line |
0 comments
|
Download
|
|
M |
content/public/test/browser_test_base.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
content/public/test/browser_test_base.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
4 chunks |
+27 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/renderer/DEPS
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
|
A + |
content/renderer/cpp_bound_class_unittest.cc
|
View
|
1
2
3
4
5
6
|
7 chunks |
+72 lines, -149 lines |
0 comments
|
Download
|
|
A + |
content/renderer/dom_operations_browsertest.cc
|
View
|
1
2
|
3 chunks |
+72 lines, -70 lines |
0 comments
|
Download
|
|
A + |
content/renderer/dom_serializer_browsertest.cc
|
View
|
1
2
3
4
5
6
|
10 chunks |
+713 lines, -576 lines |
0 comments
|
Download
|
|
A + |
content/renderer/resource_fetcher_browsertest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
6 chunks |
+171 lines, -102 lines |
0 comments
|
Download
|
|
M |
webkit/chromeos/fileapi/file_access_permissions.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
webkit/chromeos/fileapi/file_access_permissions_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
D |
webkit/chromeos/fileapi/memory_file_util.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -150 lines |
0 comments
|
Download
|
|
D |
webkit/chromeos/fileapi/memory_file_util.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -587 lines |
0 comments
|
Download
|
|
D |
webkit/chromeos/fileapi/memory_file_util_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -839 lines |
0 comments
|
Download
|
|
M |
webkit/glue/cpp_binding_example.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
webkit/glue/cpp_bound_class.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
D |
webkit/glue/cpp_bound_class_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -306 lines |
0 comments
|
Download
|
|
D |
webkit/glue/dom_operations_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -133 lines |
0 comments
|
Download
|
|
D |
webkit/glue/dom_serializer_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -876 lines |
0 comments
|
Download
|
|
D |
webkit/glue/resource_fetcher_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -217 lines |
0 comments
|
Download
|
|
D |
webkit/glue/unittest_test_server.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
|
M |
webkit/glue/webkit_glue.gypi
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
D |
webkit/mocks/mock_resource_loader_bridge.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -46 lines |
0 comments
|
Download
|
|
M |
webkit/plugins/ppapi/ppapi_unittest.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
webkit/plugins/ppapi/ppapi_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
5 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
D |
webkit/tools/test_shell/mock_spellcheck_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -80 lines |
0 comments
|
Download
|
|
D |
webkit/tools/test_shell/plugin_tests.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -201 lines |
0 comments
|
Download
|
|
M |
webkit/tools/test_shell/run_all_tests.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+2 lines, -100 lines |
0 comments
|
Download
|
|
M |
webkit/tools/test_shell/test_shell.gypi
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -91 lines |
0 comments
|
Download
|
|
M |
webkit/user_agent/user_agent_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|