Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14301003: Rename FeatureObserver to UseCounter to make clear that all it stores are usage counts. (Closed)

Created:
7 years, 8 months ago by eseidel
Modified:
7 years, 8 months ago
CC:
blink-reviews, abarth-chromium, gavinp+loader_chromium.org, jchaffraix+rendering, haraken, Nate Chapin, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Rename FeatureObserver to UseCounter to make clear that all it stores are usage counts. I also added a comment to the top of UseCounter.h which references Chrome's privacy policy and explains when use-count data is ever submitted to Google. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148497

Patch Set 1 #

Patch Set 2 : Now with 20% more awesome #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -334 lines) Patch
M Source/WebCore/WebCore.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/WebCore/dom/EventTarget.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/html/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/DateInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/DateTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/DateTimeLocalInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/EmailInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/HTMLDataListElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLFormControlElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/WebCore/html/HTMLTextFormControlElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/InputType.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/InputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/MonthInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/NumberInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/RangeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/SearchInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/TelephoneInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/TextInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/TimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/URLInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/WeekInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/page/ContentSecurityPolicy.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/WebCore/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/WebCore/page/FeatureObserver.h View 1 chunk +0 lines, -139 lines 0 comments Download
D Source/WebCore/page/FeatureObserver.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/WebCore/page/Page.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/WebCore/page/UseCounter.h View 1 3 chunks +22 lines, -15 lines 1 comment Download
A + Source/WebCore/page/UseCounter.cpp View 1 4 chunks +12 lines, -13 lines 0 comments Download
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/workers/SharedWorker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/workers/Worker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObj.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
Missing UseCounter.{h,cpp}?
7 years, 8 months ago (2013-04-16 18:31:22 UTC) #1
eseidel
PTAL
7 years, 8 months ago (2013-04-16 21:20:01 UTC) #2
darin (slow to review)
LGTM https://codereview.chromium.org/14301003/diff/3001/Source/WebCore/page/UseCounter.h File Source/WebCore/page/UseCounter.h (right): https://codereview.chromium.org/14301003/diff/3001/Source/WebCore/page/UseCounter.h#newcode40 Source/WebCore/page/UseCounter.h:40: // Blink are used on real web pages. ...
7 years, 8 months ago (2013-04-16 21:28:51 UTC) #3
eseidel
7 years, 8 months ago (2013-04-16 21:47:19 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r148497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698