Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: Source/WebCore/page/UseCounter.h

Issue 14301003: Rename FeatureObserver to UseCounter to make clear that all it stores are usage counts. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Now with 20% more awesome Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/page/Page.cpp ('k') | Source/WebCore/page/UseCounter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/page/UseCounter.h
diff --git a/Source/WebCore/page/FeatureObserver.h b/Source/WebCore/page/UseCounter.h
similarity index 80%
rename from Source/WebCore/page/FeatureObserver.h
rename to Source/WebCore/page/UseCounter.h
index 55b4092157a24a33dc0823b6c464811941a334f3..8356e12368507e21088f6e7f86d02b4d92b40d40 100644
--- a/Source/WebCore/page/FeatureObserver.h
+++ b/Source/WebCore/page/UseCounter.h
@@ -23,8 +23,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef FeatureObserver_h
-#define FeatureObserver_h
+#ifndef UseCounter_h
+#define UseCounter_h
#include <wtf/BitVector.h>
#include <wtf/Noncopyable.h>
@@ -36,11 +36,19 @@ namespace WebCore {
class DOMWindow;
class Document;
-class FeatureObserver {
- WTF_MAKE_NONCOPYABLE(FeatureObserver);
+// UseCounter is used for counting the number of times features of
+// Blink are used on real web pages. The counts are submitted
darin (slow to review) 2013/04/16 21:28:51 nit: You might consider revisions to this wording
+// anonymously through the Histogram recording system in Chrome
+// for users who opt-in to "Usage Statistics" submission
+// during their install of Google Chrome:
+// http://www.google.com/chrome/intl/en/privacy.html
+// These numbers are used to help us know how commonly features of
+// Blink are used, and thus when it's safe to remove or change them.
+class UseCounter {
+ WTF_MAKE_NONCOPYABLE(UseCounter);
public:
- FeatureObserver();
- ~FeatureObserver();
+ UseCounter();
+ ~UseCounter();
enum Feature {
PageDestruction,
@@ -111,29 +119,28 @@ public:
NumberOfFeatures, // This enum value must be last.
};
+ // "observe" sets the bit for this feature to 1. Repeated calls are ignored.
static void observe(Document*, Feature);
static void observe(DOMWindow*, Feature);
void didCommitLoad();
- const BitVector* accumulatedFeatureBits() const { return m_featureBits.get(); }
-
private:
void didObserve(Feature feature)
{
ASSERT(feature != PageDestruction); // PageDestruction is reserved as a scaling factor.
ASSERT(feature < NumberOfFeatures);
- if (!m_featureBits) {
- m_featureBits = adoptPtr(new BitVector(NumberOfFeatures));
- m_featureBits->clearAll();
+ if (!m_countBits) {
+ m_countBits = adoptPtr(new BitVector(NumberOfFeatures));
+ m_countBits->clearAll();
}
- m_featureBits->quickSet(feature);
+ m_countBits->quickSet(feature);
}
void updateMeasurements();
- OwnPtr<BitVector> m_featureBits;
+ OwnPtr<BitVector> m_countBits;
};
} // namespace WebCore
-
-#endif // FeatureObserver_h
+
+#endif // UseCounter_h
« no previous file with comments | « Source/WebCore/page/Page.cpp ('k') | Source/WebCore/page/UseCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698