Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: Source/WebCore/page/UseCounter.cpp

Issue 14301003: Rename FeatureObserver to UseCounter to make clear that all it stores are usage counts. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Now with 20% more awesome Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/page/UseCounter.cpp
diff --git a/Source/WebCore/page/FeatureObserver.cpp b/Source/WebCore/page/UseCounter.cpp
similarity index 77%
rename from Source/WebCore/page/FeatureObserver.cpp
rename to Source/WebCore/page/UseCounter.cpp
index 34fb5963ae0df9256d52d2889fc7ebaee7e6d4d3..35eb07474e73b3f1423f8c9d1d0aa63a1d90138c 100644
--- a/Source/WebCore/page/FeatureObserver.cpp
+++ b/Source/WebCore/page/UseCounter.cpp
@@ -24,7 +24,7 @@
*/
#include "config.h"
-#include "FeatureObserver.h"
+#include "UseCounter.h"
#include "DOMWindow.h"
#include "Document.h"
@@ -33,11 +33,11 @@
namespace WebCore {
-FeatureObserver::FeatureObserver()
+UseCounter::UseCounter()
{
}
-FeatureObserver::~FeatureObserver()
+UseCounter::~UseCounter()
{
// We always log PageDestruction so that we have a scale for the rest of the features.
HistogramSupport::histogramEnumeration("WebCore.FeatureObserver", PageDestruction, NumberOfFeatures);
@@ -45,29 +45,28 @@ FeatureObserver::~FeatureObserver()
updateMeasurements();
}
-void FeatureObserver::updateMeasurements()
+void UseCounter::updateMeasurements()
{
HistogramSupport::histogramEnumeration("WebCore.FeatureObserver", PageVisits, NumberOfFeatures);
- if (!m_featureBits)
+ if (!m_countBits)
return;
for (unsigned i = 0; i < NumberOfFeatures; ++i) {
- if (m_featureBits->quickGet(i))
+ if (m_countBits->quickGet(i))
HistogramSupport::histogramEnumeration("WebCore.FeatureObserver", i, NumberOfFeatures);
}
- // Clearing feature bits is timing sensitive. Ports other than chromium do not use HistogramSupport,
- // and pull the results on certain navigation events instead.
- m_featureBits->clearAll();
+ // Clearing count bits is timing sensitive.
+ m_countBits->clearAll();
}
-void FeatureObserver::didCommitLoad()
+void UseCounter::didCommitLoad()
{
updateMeasurements();
}
-void FeatureObserver::observe(Document* document, Feature feature)
+void UseCounter::observe(Document* document, Feature feature)
{
if (!document)
return;
@@ -76,10 +75,10 @@ void FeatureObserver::observe(Document* document, Feature feature)
if (!page)
return;
- page->featureObserver()->didObserve(feature);
+ page->useCounter()->didObserve(feature);
}
-void FeatureObserver::observe(DOMWindow* domWindow, Feature feature)
+void UseCounter::observe(DOMWindow* domWindow, Feature feature)
{
ASSERT(domWindow);
observe(domWindow->document(), feature);

Powered by Google App Engine
This is Rietveld 408576698