Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 143003028: A64: More fixes to enable building for Android Arm64 (Closed)

Created:
6 years, 10 months ago by rmcilroy
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: More fixes to enable building for Android Arm64 - Fix android_target_arch after Android platform rename. - Specify gcc tool names rather than using wildcards (this breaks in newer NDK versions due to matching multiple tools in some cases. - Add missing non-simulator supportt to test-assembler-a64 - Avoid ambiguous pow(int, int) error messages in test-platform.cc - Add support for GET_STACK_POINTER in test-platform.cc R=rodolph.perfetta@arm.com Committed: https://code.google.com/p/v8/source/detail?r=19217

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Fix assembly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -37 lines) Patch
M Makefile.android View 4 chunks +20 lines, -14 lines 0 comments Download
M build/android.gypi View 1 3 chunks +16 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-a64.cc View 6 chunks +23 lines, -20 lines 0 comments Download
M test/cctest/test-platform.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmcilroy
PTAL.
6 years, 10 months ago (2014-02-07 17:10:04 UTC) #1
Rodolph Perfetta (ARM)
https://codereview.chromium.org/143003028/diff/40001/test/cctest/test-platform.cc File test/cctest/test-platform.cc (right): https://codereview.chromium.org/143003028/diff/40001/test/cctest/test-platform.cc#newcode60 test/cctest/test-platform.cc:60: ASM("mov sp, x0; str x0, %0" : "=g" (sp_addr) ...
6 years, 10 months ago (2014-02-07 17:53:11 UTC) #2
rmcilroy
https://codereview.chromium.org/143003028/diff/40001/test/cctest/test-platform.cc File test/cctest/test-platform.cc (right): https://codereview.chromium.org/143003028/diff/40001/test/cctest/test-platform.cc#newcode60 test/cctest/test-platform.cc:60: ASM("mov sp, x0; str x0, %0" : "=g" (sp_addr) ...
6 years, 10 months ago (2014-02-07 19:02:09 UTC) #3
Rodolph Perfetta (ARM)
lgtm
6 years, 10 months ago (2014-02-07 19:23:33 UTC) #4
rmcilroy
6 years, 10 months ago (2014-02-10 09:16:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698