A64: More fixes to enable building for Android Arm64

test/cctest/test-platform.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 35 matching lines @@
   static int sp_addr = 0; \
   do { \
     ASM("mov %%esp, %0" : "=g" (sp_addr)); \
   } while (0)
 #elif defined(__ARMEL__)
 #define GET_STACK_POINTER() \
   static int sp_addr = 0; \
   do { \
     ASM("str %%sp, %0" : "=g" (sp_addr)); \
   } while (0)
+#elif defined(__AARCH64EL__)
+#define GET_STACK_POINTER() \
+  static int sp_addr = 0; \
+  do { \
+    ASM("mov sp, x0; str x0, %0" : "=g" (sp_addr) : : "x0"); \

[Rodolph Perfetta (ARM), 2014/02/07 17:53:11]

You are moving x0 into sp, not what you meant.

As a side I wouldn't use x0, use ip0. this way you don;t for the compiler to
save and restore it.

[rmcilroy, 2014/02/07 19:02:09]

Done, thanks.  The assembler didn't know what ip0 was, so I've used x16 which
should be the same.

+  } while (0)
 #elif defined(__MIPSEL__)
 #define GET_STACK_POINTER() \
   static int sp_addr = 0; \
   do { \
     ASM("sw $sp, %0" : "=g" (sp_addr)); \
   } while (0)
 #else
 #error Host architecture was not detected as supported by v8
 #endif
 
@@ skipping 17 matching lines @@
       "}");
 
   v8::Local<v8::Object> global_object = env->Global();
   v8::Local<v8::Function> foo =
       v8::Local<v8::Function>::Cast(global_object->Get(v8_str("foo")));
 
   v8::Local<v8::Value> result = foo->Call(global_object, 0, NULL);
   CHECK_EQ(0, result->Int32Value() % OS::ActivationFrameAlignment());
 }
 
 #undef GET_STACK_POINTERS

[Rodolph Perfetta (ARM), 2014/02/07 17:53:11]

not part of your patch but there shouldn't be an S at the end.

 #undef ASM
 #endif  // __GNUC__