Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1429863009: Use a struct for client GL texture handles (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use a struct for client GL texture handles Committed: https://skia.googlesource.com/skia/+/091f60c2a0e4504c017b8a67ff96a0e829519b14

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : update #

Patch Set 4 : android #

Patch Set 5 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -86 lines) Patch
M gm/imagefromyuvtextures.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLTypes.h View 1 1 chunk +13 lines, -0 lines 1 comment Download
M src/gpu/gl/GrGLGpu.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 12 chunks +75 lines, -46 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 1 chunk +11 lines, -7 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M tests/GrSurfaceTest.cpp View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bsalomon
5 years, 1 month ago (2015-11-10 18:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429863009/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429863009/80001
5 years, 1 month ago (2015-11-10 18:59:38 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-10 18:59:39 UTC) #6
egdaniel
lgtm with really important nit https://codereview.chromium.org/1429863009/diff/80001/include/gpu/gl/GrGLTypes.h File include/gpu/gl/GrGLTypes.h (right): https://codereview.chromium.org/1429863009/diff/80001/include/gpu/gl/GrGLTypes.h#newcode67 include/gpu/gl/GrGLTypes.h:67: struct GrGLTextureInfo { Can ...
5 years, 1 month ago (2015-11-10 19:53:47 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 19:54:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/091f60c2a0e4504c017b8a67ff96a0e829519b14

Powered by Google App Engine
This is Rietveld 408576698