[cr tool] Make context implicit

[cr tool] Make context implicit

This removes context from many function signatures, and instead adds cr.context to access the current context.
This will allow a few places that are currently ugly to be cleaned up, make it possible to access the context from inside some properties, and make it easy to hijack for testing purposes.

BUG=336240
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258609

[Andrew Hayden (chromium.org), 2014-03-19 18:20:06]

All I see are issues with comments, so LGTM.

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/androi...
File tools/cr/cr/base/android.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/androi...
tools/cr/cr/base/android.py:64: # Run env setup and capture/parse it's output
Grammar police ftw

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/contex...
File tools/cr/cr/base/context.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/contex...
tools/cr/cr/base/context.py:104: This is passed to almost all methods in the cr
system, and holds the common
No longer passed at all.

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/host.py
File tools/cr/cr/base/host.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/host.p...
tools/cr/cr/base/host.py:51: issues. The command is expanded in the so that
context variables
Search and replace is not your friend.

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/loader.py
File tools/cr/cr/loader.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/loader.py#n...
tools/cr/cr/loader.py:112: print "Cannot load all of", remains
I think you want one more space here, yes?

[iancottrell, 2014-03-19 22:17:11]

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/androi...
File tools/cr/cr/base/android.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/androi...
tools/cr/cr/base/android.py:64: # Run env setup and capture/parse it's output
On 2014/03/19 18:20:06, Andrew Hayden wrote:
> Grammar police ftw

Done.

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/contex...
File tools/cr/cr/base/context.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/contex...
tools/cr/cr/base/context.py:104: This is passed to almost all methods in the cr
system, and holds the common
On 2014/03/19 18:20:06, Andrew Hayden wrote:
> No longer passed at all.

Done.

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/host.py
File tools/cr/cr/base/host.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/base/host.p...
tools/cr/cr/base/host.py:51: issues. The command is expanded in the so that
context variables
On 2014/03/19 18:20:06, Andrew Hayden wrote:
> Search and replace is not your friend.

Unfortunately none of this change was amenable to search and replace, it was all
done by hand. This was probably me getting stuck trying to reword, going for
coffee, and then forgetting what I was doing when I came back :)

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/loader.py
File tools/cr/cr/loader.py (right):

https://codereview.chromium.org/142933004/diff/220001/tools/cr/cr/loader.py#n...
tools/cr/cr/loader.py:112: print "Cannot load all of", remains
On 2014/03/19 18:20:06, Andrew Hayden wrote:
> I think you want one more space here, yes?

No, print adds the space for you.

[Andrew Hayden (chromium.org), 2014-03-20 08:08:50]

> No, print adds the space for you.
Python sometimes makes me happy, sometimes makes me sad, and sometimes makes me
scratch my head. I think this one makes me scratch my head, but I don't hate it.
Learned something new today, hooray!

Still LGTM, ship this thing.

[rmcilroy, 2014-03-20 10:28:50]

On 2014/03/20 10:21:56, ian_cottrell wrote:

Looks good.  lgtm!

[ian_cottrell, 2014-03-20 10:49:12]

The CQ bit was checked by iancottrell@chromium.org

[commit-bot: I haz the power, 2014-03-20 10:49:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/142933004/240001

[commit-bot: I haz the power, 2014-03-20 11:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 11:18:29]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[ian_cottrell, 2014-03-20 17:42:43]

The CQ bit was checked by iancottrell@chromium.org

[commit-bot: I haz the power, 2014-03-20 17:50:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/142933004/240001

[commit-bot: I haz the power, 2014-03-20 17:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 17:57:23]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[iancottrell, 2014-03-21 14:50:46]

The CQ bit was checked by iancottrell@google.com

[commit-bot: I haz the power, 2014-03-21 14:50:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/142933004/260001

[commit-bot: I haz the power, 2014-03-21 16:50:12]

Change committed as 258609