Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/cr/cr/actions/debugger.py

Issue 142933004: [cr tool] Make context implicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/cr/cr/actions/builder.py ('k') | tools/cr/cr/actions/gdb.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cr/cr/actions/debugger.py
diff --git a/tools/cr/cr/actions/debugger.py b/tools/cr/cr/actions/debugger.py
index a634ab22038dd8bbdf6290f21ee7b411214013cf..1db3d8103b8bfb8c7e82bf90a331ad94f1fd2904 100644
--- a/tools/cr/cr/actions/debugger.py
+++ b/tools/cr/cr/actions/debugger.py
@@ -22,30 +22,30 @@ class Debugger(cr.Action, cr.Plugin.Type):
cr.Runner.AddSelectorArg(command, parser)
@classmethod
- def ShouldInvoke(cls, context):
+ def ShouldInvoke(cls):
"""Checks if the debugger is attaching or launching."""
- return not cr.Runner.Skipping(context)
+ return not cr.Runner.Skipping()
@cr.Plugin.activemethod
- def Restart(self, context, targets, arguments):
+ def Restart(self, targets, arguments):
"""Ask the debugger to restart.
Defaults to a Kill Invoke sequence.
"""
- self.Kill(context, targets, [])
- self.Invoke(context, targets, arguments)
+ self.Kill(targets, [])
+ self.Invoke(targets, arguments)
@cr.Plugin.activemethod
- def Kill(self, context, targets, arguments):
+ def Kill(self, targets, arguments):
"""Kill the running debugger."""
- cr.Runner.Kill(context, targets, arguments)
+ cr.Runner.Kill(targets, arguments)
@cr.Plugin.activemethod
- def Invoke(self, context, targets, arguments):
+ def Invoke(self, targets, arguments):
"""Invoke the program within a debugger."""
raise NotImplementedError('Must be overridden.')
@cr.Plugin.activemethod
- def Attach(self, context, targets, arguments):
+ def Attach(self, targets, arguments):
"""Attach a debugger to a running program."""
raise NotImplementedError('Must be overridden.')
« no previous file with comments | « tools/cr/cr/actions/builder.py ('k') | tools/cr/cr/actions/gdb.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698