Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/cr/cr/actions/installer.py

Issue 142933004: [cr tool] Make context implicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/cr/cr/actions/gyp.py ('k') | tools/cr/cr/actions/linux.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cr/cr/actions/installer.py
diff --git a/tools/cr/cr/actions/installer.py b/tools/cr/cr/actions/installer.py
index 0dd432df6533234c43185018fad0c22b085930c2..064b4d0b8dd196b1663943603bcdde00326ad797 100644
--- a/tools/cr/cr/actions/installer.py
+++ b/tools/cr/cr/actions/installer.py
@@ -20,25 +20,25 @@ class Installer(cr.Action, cr.Plugin.Type):
SELECTOR_HELP = 'Sets the installer to use.'
@cr.Plugin.activemethod
- def Uninstall(self, context, targets, arguments):
+ def Uninstall(self, targets, arguments):
"""Removes a target from it's installed location."""
raise NotImplementedError('Must be overridden.')
@cr.Plugin.activemethod
- def Install(self, context, targets, arguments):
+ def Install(self, targets, arguments):
"""Installs a target somewhere so that it is ready to run."""
raise NotImplementedError('Must be overridden.')
@cr.Plugin.activemethod
- def Reinstall(self, context, targets, arguments):
+ def Reinstall(self, targets, arguments):
"""Force a target to install even if already installed.
Default implementation is to do an Uninstall Install sequence.
Do not call the base version if you implement a more efficient one.
"""
- self.Uninstall(context, targets, [])
- self.Install(context, targets, arguments)
+ self.Uninstall(targets, [])
+ self.Install(targets, arguments)
class SkipInstaller(Installer):
@@ -48,8 +48,8 @@ class SkipInstaller(Installer):
def priority(self):
return super(SkipInstaller, self).priority - 1
- def Uninstall(self, context, targets, arguments):
+ def Uninstall(self, targets, arguments):
pass
- def Install(self, context, targets, arguments):
+ def Install(self, targets, arguments):
pass
« no previous file with comments | « tools/cr/cr/actions/gyp.py ('k') | tools/cr/cr/actions/linux.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698