Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6716)

Unified Diff: chrome/renderer/extensions/event_unittest.cc

Issue 142863006: Remove detach_ as publicly exposed method of Event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/event.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/event_unittest.cc
diff --git a/chrome/renderer/extensions/event_unittest.cc b/chrome/renderer/extensions/event_unittest.cc
index a7d319fcff04029896244aa1da16a24fa546d034..729f5256ca79b2cea5b5677c7a8b1b1acff538a6 100644
--- a/chrome/renderer/extensions/event_unittest.cc
+++ b/chrome/renderer/extensions/event_unittest.cc
@@ -204,7 +204,7 @@ TEST_F(EventUnittest, DetachFilteredEvent) {
"var filters = {url: [{hostSuffix: 'google.com'}]};"
"e.addListener(cb1, filters);"
"e.addListener(cb2, filters);"
- "e.detach_();"
+ "privates(e).impl.detach_();"
"assert.AssertFalse(bindings.HasFilteredListener('myevent'));");
module_system_->Require("test");
}
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/event.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698