Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/renderer/extensions/event_unittest.cc

Issue 142863006: Remove detach_ as publicly exposed method of Event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/event.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/base/module_system_test.h" 5 #include "chrome/test/base/module_system_test.h"
6 6
7 #include "extensions/common/extension_urls.h" 7 #include "extensions/common/extension_urls.h"
8 #include "grit/renderer_resources.h" 8 #include "grit/renderer_resources.h"
9 9
10 namespace extensions { 10 namespace extensions {
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 "var Event = require('event_bindings').Event;" 197 "var Event = require('event_bindings').Event;"
198 "var assert = requireNative('assert');" 198 "var assert = requireNative('assert');"
199 "var bindings = requireNative('event_natives');" 199 "var bindings = requireNative('event_natives');"
200 "var eventOpts = {supportsListeners: true, supportsFilters: true};" 200 "var eventOpts = {supportsListeners: true, supportsFilters: true};"
201 "var e = new Event('myevent', undefined, eventOpts);" 201 "var e = new Event('myevent', undefined, eventOpts);"
202 "var cb1 = function() {};" 202 "var cb1 = function() {};"
203 "var cb2 = function() {};" 203 "var cb2 = function() {};"
204 "var filters = {url: [{hostSuffix: 'google.com'}]};" 204 "var filters = {url: [{hostSuffix: 'google.com'}]};"
205 "e.addListener(cb1, filters);" 205 "e.addListener(cb1, filters);"
206 "e.addListener(cb2, filters);" 206 "e.addListener(cb2, filters);"
207 "e.detach_();" 207 "privates(e).impl.detach_();"
208 "assert.AssertFalse(bindings.HasFilteredListener('myevent'));"); 208 "assert.AssertFalse(bindings.HasFilteredListener('myevent'));");
209 module_system_->Require("test"); 209 module_system_->Require("test");
210 } 210 }
211 211
212 TEST_F(EventUnittest, AttachAndRemoveSameFilteredEventListener) { 212 TEST_F(EventUnittest, AttachAndRemoveSameFilteredEventListener) {
213 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 213 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
214 RegisterModule("test", 214 RegisterModule("test",
215 "var Event = require('event_bindings').Event;" 215 "var Event = require('event_bindings').Event;"
216 "var assert = requireNative('assert');" 216 "var assert = requireNative('assert');"
217 "var bindings = requireNative('event_natives');" 217 "var bindings = requireNative('event_natives');"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 " e.addListener(cb);" 267 " e.addListener(cb);"
268 "} catch (e) {" 268 "} catch (e) {"
269 " caught = true;" 269 " caught = true;"
270 "}" 270 "}"
271 "assert.AssertTrue(caught);"); 271 "assert.AssertTrue(caught);");
272 module_system_->Require("test"); 272 module_system_->Require("test");
273 } 273 }
274 274
275 } // namespace 275 } // namespace
276 } // namespace extensions 276 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/event.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698