chrome/renderer/resources/extensions/event.js - Issue 142863006: Remove detach_ as publicly exposed method of Event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/event.js

Issue 142863006: Remove detach_ as publicly exposed method of Event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/event.js

diff --git a/chrome/renderer/resources/extensions/event.js b/chrome/renderer/resources/extensions/event.js

index 59d2b3c832dd6467f0bf1851b849eef18ab3e39a..ae2bfdf730a17bad6c2ffa2a152ac263fcd457fa 100644

--- a/chrome/renderer/resources/extensions/event.js

+++ b/chrome/renderer/resources/extensions/event.js

@@ -520,7 +520,6 @@

// TODO(fsamuel): We really shouldn't be exposing these private methods

// but certain tests rely on them.

'attach_',

- 'detach_',

'dispatch_'

]);

« no previous file with comments | « chrome/renderer/extensions/event_unittest.cc ('k') | no next file » | no next file with comments »