Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1427973008: Oilpan: annotate weak ScrollableArea* refs with GC_PLUGIN_IGNORE()s. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, danakj, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-animation_chromium.org, dshwang, rjwright, jbroman, Justin Novosad, blink-layers+watch_chromium.org, shans, Rik, f(malita), darktears, blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, Eric Willigers, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: annotate weak ScrollableArea* refs with GC_PLUGIN_IGNORE()s. ScrollAnimators keep a back reference to their owning ScrollableArea; annotate these weak references with GC_PLUGIN_IGNORE() to inform the GC plugin checks that these references have been checked & accounted for. R=haraken BUG=509911, 553613 Committed: https://crrev.com/9addd2929427560195198689d1ef63193b4ad006 Cr-Commit-Position: refs/heads/master@{#358747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. I don't understand why some builds will have the full type ...
5 years, 1 month ago (2015-11-09 22:06:12 UTC) #4
haraken
LGTM
5 years, 1 month ago (2015-11-09 22:08:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427973008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427973008/1
5 years, 1 month ago (2015-11-09 22:10:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 02:00:15 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 02:01:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9addd2929427560195198689d1ef63193b4ad006
Cr-Commit-Position: refs/heads/master@{#358747}

Powered by Google App Engine
This is Rietveld 408576698