Oilpan: annotate weak ScrollableArea* refs with GC_PLUGIN_IGNORE()s.

Oilpan: annotate weak ScrollableArea* refs with GC_PLUGIN_IGNORE()s.

ScrollAnimators keep a back reference to their owning ScrollableArea;
annotate these weak references with GC_PLUGIN_IGNORE() to inform
the GC plugin checks that these references have been checked & accounted
for.

R=haraken
BUG=509911, 553613
Committed: https://crrev.com/9addd2929427560195198689d1ef63193b4ad006
Cr-Commit-Position: refs/heads/master@{#358747}

[sof, 2015-11-09 21:58:33]

Description was changed from

==========
Oilpan: add missing GC_PLUGIN_IGNORE()s to ScrollableArea* fields.

ScrollAnimators keep a back reference to their owning ScrollableArea;
annotate these weak references with GC_PLUGIN_IGNORE() to inform
the GC plugin checks that these references have been checked & accounted
for.

R=
BUG=509911
==========

to

==========
Oilpan: add missing GC_PLUGIN_IGNORE()s to ScrollableArea* fields.

ScrollAnimators keep a back reference to their owning ScrollableArea;
annotate these weak references with GC_PLUGIN_IGNORE() to inform
the GC plugin checks that these references have been checked & accounted
for.

R=
BUG=509911,553613
==========

[sof, 2015-11-09 21:59:31]

Description was changed from

==========
Oilpan: add missing GC_PLUGIN_IGNORE()s to ScrollableArea* fields.

ScrollAnimators keep a back reference to their owning ScrollableArea;
annotate these weak references with GC_PLUGIN_IGNORE() to inform
the GC plugin checks that these references have been checked & accounted
for.

R=
BUG=509911,553613
==========

to

==========
Oilpan: annotate weak ScrollableArea* refs with GC_PLUGIN_IGNORE()s.

ScrollAnimators keep a back reference to their owning ScrollableArea;
annotate these weak references with GC_PLUGIN_IGNORE() to inform
the GC plugin checks that these references have been checked & accounted
for.

R=
BUG=509911,553613
==========

[sof, 2015-11-09 22:06:12]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-11-09 22:06:12]

please take a look.

I don't understand why some builds will have the full type of ScrollableArea in
scope when processing the affected header files here; something that our trybots
don't run into (nor is it an issue locally with an up-to-date GC plugin and
clang).

That said, these raw pointers to the ScrollableArea mixin heap objects must be
accounted for, but weren't. Do so the "easy way" here by using
GC_PLUGIN_IGNORE() -- the owning ScrollableArea takes care of severing the
connection at the end of its lifetime.

[haraken, 2015-11-09 22:08:15]

LGTM

[sof, 2015-11-09 22:09:04]

Description was changed from

==========
Oilpan: annotate weak ScrollableArea* refs with GC_PLUGIN_IGNORE()s.

ScrollAnimators keep a back reference to their owning ScrollableArea;
annotate these weak references with GC_PLUGIN_IGNORE() to inform
the GC plugin checks that these references have been checked & accounted
for.

R=
BUG=509911,553613
==========

to

==========
Oilpan: annotate weak ScrollableArea* refs with GC_PLUGIN_IGNORE()s.

ScrollAnimators keep a back reference to their owning ScrollableArea;
annotate these weak references with GC_PLUGIN_IGNORE() to inform
the GC plugin checks that these references have been checked & accounted
for.

R=haraken
BUG=509911,553613
==========

[sof, 2015-11-09 22:09:12]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-09 22:10:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427973008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427973008/1

[commit-bot: I haz the power, 2015-11-10 02:00:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-10 02:01:13]

Patchset 1 (id:??) landed as
https://crrev.com/9addd2929427560195198689d1ef63193b4ad006
Cr-Commit-Position: refs/heads/master@{#358747}