Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1427733003: Use |FrameSelection::selectedText()| where possible. (Closed)

Created:
5 years, 1 month ago by kotenkov
Modified:
5 years, 1 month ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use |FrameSelection::selectedText()| where possible. Partially reland https://codereview.chromium.org/1377963004/, except for changes in |WebLocalFrameImpl::selectionAsText()|. Substitute occurrences of selection -> range -> (text or html) conversions with direct selection -> (text or html) conversions using existing functions. BUG=545746 Committed: https://crrev.com/a728430c10449ebafdc4ca4eece40c40ec2b07a1 Cr-Commit-Position: refs/heads/master@{#357309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kotenkov
Hello, Yosin! Sorry for the delay. I've split the changes in two patches as you ...
5 years, 1 month ago (2015-11-01 08:26:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427733003/1
5 years, 1 month ago (2015-11-02 03:47:36 UTC) #4
yosin_UTC9
lgtm +tkent@ for OWNERS review.
5 years, 1 month ago (2015-11-02 03:48:24 UTC) #6
tkent
lgtm
5 years, 1 month ago (2015-11-02 04:58:33 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 05:21:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427733003/1
5 years, 1 month ago (2015-11-02 05:49:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 05:53:29 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 05:54:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a728430c10449ebafdc4ca4eece40c40ec2b07a1
Cr-Commit-Position: refs/heads/master@{#357309}

Powered by Google App Engine
This is Rietveld 408576698