third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp - Issue 1427733003: Use |FrameSelection::selectedText()| where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 1427733003: Use |FrameSelection::selectedText()| where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/serializers/Serialization.cpp ('k') | third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

index fa2e1eca65f65d5a194bd55ba886595fbda41876..635a6a487ce432ca1cd2996ac698d0a7e04cb093 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

@@ -307,8 +307,7 @@ void HTMLTextAreaElement::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*

// that case, and nothing in the text field will be removed.

unsigned selectionLength = 0;

if (focused()) {

- const EphemeralRange range = document().frame()->selection().selection().toNormalizedEphemeralRange();

- selectionLength = computeLengthForSubmission(plainText(range));

+ selectionLength = computeLengthForSubmission(document().frame()->selection().selectedText());

}

ASSERT(currentLength >= selectionLength);

unsigned baseLength = currentLength - selectionLength;