Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1427653002: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step1) (Closed)

Created:
5 years, 1 month ago by pfeldman
Modified:
5 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, yurys, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step1) BUG=547658 NOTRY=true Committed: https://crrev.com/7d50582d7731557e625b2ef466e60d91e196be63 Cr-Commit-Position: refs/heads/master@{#356433}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebaselined #

Messages

Total messages: 13 (6 generated)
pfeldman
5 years, 1 month ago (2015-10-27 19:15:11 UTC) #2
dgozman
lgtm
5 years, 1 month ago (2015-10-27 21:39:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427653002/20001
5 years, 1 month ago (2015-10-27 21:39:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/115436) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-10-27 21:44:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427653002/40001
5 years, 1 month ago (2015-10-27 23:10:01 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-27 23:35:11 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 23:36:02 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7d50582d7731557e625b2ef466e60d91e196be63
Cr-Commit-Position: refs/heads/master@{#356433}

Powered by Google App Engine
This is Rietveld 408576698