third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html - Issue 1427653002: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html

Issue 1427653002: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html ('k') | third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html

index 7e1171feef6647124057ec8741d32942ff362353..dbc7a08be133adce5617715b8532bbd2a3ed10e5 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html

@@ -48,8 +48,8 @@ function test()

{

InspectorTest.addResult("Script source was shown.");

shownSourceFrame = sourceFrame;

- InspectorTest.addSniffer(WebInspector.SourceFrame.prototype, "addMessageToSource", didAddMessage);

- InspectorTest.addSniffer(WebInspector.SourceFrame.prototype, "clearMessages", clearMessages);

+ InspectorTest.addSniffer(WebInspector.UISourceCodeFrame.prototype, "addMessageToSource", didAddMessage);

+ InspectorTest.addSniffer(WebInspector.UISourceCodeFrame.prototype, "clearMessages", clearMessages);

InspectorTest.evaluateInPage("addErrorToConsole()");

}

@@ -57,7 +57,7 @@ function test()

{

if (this !== shownSourceFrame)

return;

- InspectorTest.addResult("Message added to source frame: " + message.messageText());

+ InspectorTest.addResult("Message added to source frame: " + message.text());

InspectorTest.consoleModel.requestClearMessages();

}