Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1427653002: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step1) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
index 25ebafdaa8f25616c7fc523ddf66360042e6a092..25fdfaced4dc3200a1e445d8792db67bd529d447 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
@@ -415,7 +415,7 @@ WebInspector.JavaScriptSourceFrame.prototype = {
var compileError = errorData.compileError;
if (compileError) {
var messageText = WebInspector.UIString("LiveEdit compile failed: %s", compileError.message);
- var message = new WebInspector.SourceFrameMessage(messageText, WebInspector.SourceFrameMessage.Level.Error, compileError.lineNumber - 1, compileError.columnNumber + 1);
+ var message = new WebInspector.UISourceCode.Message(WebInspector.UISourceCode.Message.Level.Error, messageText, compileError.lineNumber - 1, compileError.columnNumber + 1);
this.addMessageToSource(message);
} else {
WebInspector.console.addMessage(WebInspector.UIString("Unknown LiveEdit error: %s; %s", JSON.stringify(errorData), error), warningLevel);
@@ -985,11 +985,11 @@ WebInspector.JavaScriptSourceFrame.prototype = {
/**
* @param {!WebInspector.PresentationConsoleMessage} message
- * @return {!WebInspector.SourceFrameMessage}
+ * @return {!WebInspector.UISourceCode.Message}
*/
_sourceFrameMessage: function(message)
{
- return WebInspector.SourceFrameMessage.fromConsoleMessage(message.originalMessage, message.lineNumber(), message.columnNumber());
+ return WebInspector.UISourceCodeFrame.uiMessageFromConsoleMessage(message.originalMessage, message.lineNumber(), message.columnNumber());
},
_consoleMessagesCleared: function(event)
@@ -1049,6 +1049,7 @@ WebInspector.JavaScriptSourceFrame.prototype = {
onTextEditorContentLoaded: function()
{
+ WebInspector.UISourceCodeFrame.prototype.onTextEditorContentLoaded.call(this);
if (this._executionLocation)
this.setExecutionLocation(this._executionLocation);

Powered by Google App Engine
This is Rietveld 408576698