Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1427433007: gpu/khronos_glcts_support: Move target_defaults into separate file (Closed)

Created:
5 years, 1 month ago by U. Artie Eoff
Modified:
5 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@glcts
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu/khronos_glcts_support: Move target_defaults into separate file Move the target_defaults into its own gypi file so that we can parse the variables in khronos_glcts.gypi with the gypi_to_gn.py script. The gypi_to_gn.py chokes on target_defaults. BUG=chromium:412865, chromium:471903 R=kbr@chromium.org, piman@chromium.org, dpranke@chromium.org TEST=Verify khronos_glcts_test builds and runs Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>; Committed: https://crrev.com/f1f30573fd0060132feee853ec26e744ed09fe11 Cr-Commit-Position: refs/heads/master@{#356711}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
M gpu/khronos_glcts_support/khronos_glcts.gypi View 1 chunk +0 lines, -28 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_cts.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A gpu/khronos_glcts_support/khronos_glcts_defaults.gypi View 1 chunk +34 lines, -0 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_framework.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_gtf.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
U. Artie Eoff
5 years, 1 month ago (2015-10-28 23:46:53 UTC) #1
Dirk Pranke
I defer this one to kbr or piman.
5 years, 1 month ago (2015-10-28 23:47:57 UTC) #2
piman
lgtm
5 years, 1 month ago (2015-10-29 00:10:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427433007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427433007/20001
5 years, 1 month ago (2015-10-29 00:29:20 UTC) #5
Ken Russell (switch to Gerrit)
LGTM too. Thanks.
5 years, 1 month ago (2015-10-29 00:37:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 00:55:25 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 00:56:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1f30573fd0060132feee853ec26e744ed09fe11
Cr-Commit-Position: refs/heads/master@{#356711}

Powered by Google App Engine
This is Rietveld 408576698