Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1413303003: gpu/khronos_glcts_support: add support for GN builds (Closed)

Created:
5 years, 1 month ago by U. Artie Eoff
Modified:
5 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@glcts2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu/khronos_glcts_support: add support for GN builds Port the GYP configs to BUILD.gn so that this test can be built with GN. BUG=chromium:412865, chromium:471903 R=kbr@chromium.org, piman@chromium.org, dpranke@chromium.org, brettw@chromium.org TEST=Verify khronos_glcts_test builds and runs with GN build Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>; Committed: https://crrev.com/cfd8141a4f2b970a8c9ba6d70a541a4490011284 Cr-Commit-Position: refs/heads/master@{#356871}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -3 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/khronos_glcts_support/BUILD.gn View 2 chunks +544 lines, -3 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 16 (4 generated)
U. Artie Eoff
5 years, 1 month ago (2015-10-28 23:47:02 UTC) #1
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-28 23:48:32 UTC) #2
piman
lgtm
5 years, 1 month ago (2015-10-29 00:10:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413303003/20001
5 years, 1 month ago (2015-10-29 00:31:50 UTC) #5
Ken Russell (switch to Gerrit)
Thanks for taking care of this. LGTM after the fact. https://codereview.chromium.org/1413303003/diff/20001/gpu/khronos_glcts_support/BUILD.gn File gpu/khronos_glcts_support/BUILD.gn (right): https://codereview.chromium.org/1413303003/diff/20001/gpu/khronos_glcts_support/BUILD.gn#newcode75 ...
5 years, 1 month ago (2015-10-29 00:35:30 UTC) #6
U. Artie Eoff
https://codereview.chromium.org/1413303003/diff/20001/gpu/khronos_glcts_support/BUILD.gn File gpu/khronos_glcts_support/BUILD.gn (right): https://codereview.chromium.org/1413303003/diff/20001/gpu/khronos_glcts_support/BUILD.gn#newcode75 gpu/khronos_glcts_support/BUILD.gn:75: configs += [ "//build/config/compiler:rtti" ] On 2015/10/29 00:35:30, Ken ...
5 years, 1 month ago (2015-10-29 00:46:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/113707)
5 years, 1 month ago (2015-10-29 00:57:01 UTC) #9
U. Artie Eoff
Looks like we still need Owner review for the ".gn" change.
5 years, 1 month ago (2015-10-29 01:12:57 UTC) #11
jam
lgtm
5 years, 1 month ago (2015-10-29 16:18:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413303003/20001
5 years, 1 month ago (2015-10-29 16:23:50 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 17:04:59 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 17:05:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cfd8141a4f2b970a8c9ba6d70a541a4490011284
Cr-Commit-Position: refs/heads/master@{#356871}

Powered by Google App Engine
This is Rietveld 408576698