Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Issue 1412793010: gpu/khronos_glcts_support: use override specifier (Closed)

Created:
5 years, 1 month ago by U. Artie Eoff
Modified:
5 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu/khronos_glcts_support: use override specifier Annotate the base class override functions with the override specifier to appease the chromium-style checker. BUG=chromium:412865 R=kbr@chromium.org, piman@chromium.org, dpranke@chromium.org TEST=Verify khronos_glcts_test builds and runs Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>; Committed: https://crrev.com/93489a38d20cc3c877d6362edbe779e76b6c6623 Cr-Commit-Position: refs/heads/master@{#356710}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M gpu/khronos_glcts_support/native/egl_native_windowless.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
U. Artie Eoff
5 years, 1 month ago (2015-10-28 23:46:40 UTC) #1
Dirk Pranke
I defer this one to kbr or piman.
5 years, 1 month ago (2015-10-28 23:47:24 UTC) #2
piman
lgtm
5 years, 1 month ago (2015-10-29 00:09:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412793010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412793010/20001
5 years, 1 month ago (2015-10-29 00:29:18 UTC) #5
Ken Russell (switch to Gerrit)
Thanks. LGTM after the fact.
5 years, 1 month ago (2015-10-29 00:36:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 00:55:05 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 00:55:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93489a38d20cc3c877d6362edbe779e76b6c6623
Cr-Commit-Position: refs/heads/master@{#356710}

Powered by Google App Engine
This is Rietveld 408576698