Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1427143003: include what you use: errno.h and string.h in net/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h and string.h in net/ Adding some missing errno.h and string.h includes. Committed: https://crrev.com/82ccf4656fbc6819e5dcbe507751e1d29691fc31 Cr-Commit-Position: refs/heads/master@{#358844}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M net/socket/tcp_socket_win.cc View 1 chunk +1 line, -0 lines 3 comments Download
M net/tools/flip_server/acceptor_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/flip_server/create_listener.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/flip_server/flip_in_mem_edsm_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_socket_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Mostyn Bramley-Moore
@xunjieli: here are some include-what-you-use fixes.
5 years, 1 month ago (2015-11-07 00:14:14 UTC) #2
xunjieli
https://codereview.chromium.org/1427143003/diff/1/net/socket/tcp_socket_win.cc File net/socket/tcp_socket_win.cc (right): https://codereview.chromium.org/1427143003/diff/1/net/socket/tcp_socket_win.cc#newcode8 net/socket/tcp_socket_win.cc:8: #include <errno.h> Why do we need this header for ...
5 years, 1 month ago (2015-11-09 21:53:29 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/1427143003/diff/1/net/socket/tcp_socket_win.cc File net/socket/tcp_socket_win.cc (right): https://codereview.chromium.org/1427143003/diff/1/net/socket/tcp_socket_win.cc#newcode8 net/socket/tcp_socket_win.cc:8: #include <errno.h> On 2015/11/09 21:53:29, xunjieli wrote: > Why ...
5 years, 1 month ago (2015-11-09 23:13:08 UTC) #4
xunjieli
On 2015/11/09 23:13:08, Mostyn Bramley-Moore wrote: > https://codereview.chromium.org/1427143003/diff/1/net/socket/tcp_socket_win.cc > File net/socket/tcp_socket_win.cc (right): > > https://codereview.chromium.org/1427143003/diff/1/net/socket/tcp_socket_win.cc#newcode8 ...
5 years, 1 month ago (2015-11-10 15:43:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427143003/1
5 years, 1 month ago (2015-11-10 17:09:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 17:51:21 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 17:52:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82ccf4656fbc6819e5dcbe507751e1d29691fc31
Cr-Commit-Position: refs/heads/master@{#358844}

Powered by Google App Engine
This is Rietveld 408576698