net/socket/tcp_socket_win.cc - Issue 1427143003: include what you use: errno.h and string.h in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_socket_win.cc

Issue 1427143003: include what you use: errno.h and string.h in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_socket_win.cc

diff --git a/net/socket/tcp_socket_win.cc b/net/socket/tcp_socket_win.cc

index 4fa0d556d1ec99d921de10ff8b77d2184a152854..3bd2a69deb36605b0632e76e360b1685bbb55f51 100644

--- a/net/socket/tcp_socket_win.cc

+++ b/net/socket/tcp_socket_win.cc

@@ -5,6 +5,7 @@

#include "net/socket/tcp_socket.h"

#include "net/socket/tcp_socket_win.h"

+#include <errno.h>

xunjieli 2015/11/09 21:53:29 Why do we need this header for this file?

Mostyn Bramley-Moore 2015/11/09 23:13:08 Because the errno variable is used (on line 623).

#include <mstcpip.h>

#include "base/callback_helpers.h"

« no previous file with comments | « no previous file | net/tools/flip_server/acceptor_thread.cc » ('j') | no next file with comments »