include what you use: errno.h and string.h in net/

net/socket/tcp_socket_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/tcp_socket.h"
 #include "net/socket/tcp_socket_win.h"
 
+#include <errno.h>

[xunjieli, 2015/11/09 21:53:29]

Why do we need this header for this file?

[Mostyn Bramley-Moore, 2015/11/09 23:13:08]

Because the errno variable is used (on line 623).

 #include <mstcpip.h>
 
 #include "base/callback_helpers.h"
 #include "base/logging.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/win/windows_version.h"
 #include "net/base/address_list.h"
 #include "net/base/connection_type_histograms.h"
 #include "net/base/io_buffer.h"
 #include "net/base/ip_endpoint.h"
@@ skipping 594 matching lines @@
   //
   // SO_EXCLUSIVEADDRUSE will prevent a TCP client socket from binding to an end
   // point in TIME_WAIT status. It does not have this effect for a TCP server
   // socket.
 
   BOOL true_value = 1;
   int rv = setsockopt(socket_, SOL_SOCKET, SO_EXCLUSIVEADDRUSE,
                       reinterpret_cast<const char*>(&true_value),
                       sizeof(true_value));
   if (rv < 0)
     return MapSystemError(errno);

[Mostyn Bramley-Moore, 2015/11/09 23:13:08]

Note the errno variable being used here.

   return OK;
 }
 
 int TCPSocketWin::SetReceiveBufferSize(int32 size) {
   DCHECK(CalledOnValidThread());
   return SetSocketReceiveBufferSize(socket_, size);
 }
 
 int TCPSocketWin::SetSendBufferSize(int32 size) {
   DCHECK(CalledOnValidThread());
@@ skipping 415 matching lines @@
 }
 
 bool TCPSocketWin::GetEstimatedRoundTripTime(base::TimeDelta* out_rtt) const {
   DCHECK(out_rtt);
   // TODO(bmcquade): Consider implementing using
   // GetPerTcpConnectionEStats/GetPerTcp6ConnectionEStats.
   return false;
 }
 
 }  // namespace net