Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1426803004: Made the NavigationTracingObserver always be active whenever background tracing is active (Closed)

Created:
5 years, 1 month ago by oystein (OOO til 10th of July)
Modified:
5 years, 1 month ago
Reviewers:
shatch, sky, no sievers, fmeawad
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@random_triggers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made the NavigationTracingObserver always be active whenever background tracing is active This is needed so navigation tracing triggers can be used for any scenario, not just when --enable-navigation-tracing is set. R=shatch,fmeawad Committed: https://crrev.com/537726002122ef050257948da5bd8e1b977ff8aa Cr-Commit-Position: refs/heads/master@{#357456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/tracing/navigation_tracing.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tracing/navigation_tracing.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/background_tracing_manager.h View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (6 generated)
oystein (OOO til 10th of July)
ptal!
5 years, 1 month ago (2015-10-30 21:53:03 UTC) #3
fmeawad
On 2015/10/30 21:53:03, Oystein wrote: > ptal! Does this mean it will trigger but with ...
5 years, 1 month ago (2015-10-30 22:57:21 UTC) #5
oystein (OOO til 10th of July)
On 2015/10/30 22:57:21, fmeawad wrote: > On 2015/10/30 21:53:03, Oystein wrote: > > ptal! > ...
5 years, 1 month ago (2015-10-30 23:06:19 UTC) #6
shatch
lgtm
5 years, 1 month ago (2015-11-02 15:00:16 UTC) #7
oystein (OOO til 10th of July)
+sky for chrome/browser/ui, ptal! :)
5 years, 1 month ago (2015-11-02 18:10:38 UTC) #9
oystein (OOO til 10th of July)
+sievers for content/public
5 years, 1 month ago (2015-11-02 18:11:33 UTC) #11
fmeawad
On 2015/11/02 18:11:33, Oystein wrote: > +sievers for content/public lgtm
5 years, 1 month ago (2015-11-02 18:58:32 UTC) #12
fmeawad
On 2015/11/02 18:11:33, Oystein wrote: > +sievers for content/public lgtm
5 years, 1 month ago (2015-11-02 18:58:35 UTC) #13
no sievers
On 2015/11/02 18:11:33, Oystein wrote: > +sievers for content/public lgtm
5 years, 1 month ago (2015-11-02 18:58:55 UTC) #14
sky
LGTM
5 years, 1 month ago (2015-11-02 20:24:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426803004/1
5 years, 1 month ago (2015-11-02 20:45:00 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 22:41:34 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 22:42:55 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/537726002122ef050257948da5bd8e1b977ff8aa
Cr-Commit-Position: refs/heads/master@{#357456}

Powered by Google App Engine
This is Rietveld 408576698