content/browser/tracing/background_tracing_manager_impl.h - Issue 1426803004: Made the NavigationTracingObserver always be active whenever background tracing is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/background_tracing_manager_impl.h

Issue 1426803004: Made the NavigationTracingObserver always be active whenever background tracing is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@random_triggers

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tracing/background_tracing_manager_impl.h

diff --git a/content/browser/tracing/background_tracing_manager_impl.h b/content/browser/tracing/background_tracing_manager_impl.h

index 5941bba92e0c65b60d3a2ba64b6d4165171ac3af..565278276b7017b37fe33664cccb43392e9cb30c 100644

--- a/content/browser/tracing/background_tracing_manager_impl.h

+++ b/content/browser/tracing/background_tracing_manager_impl.h

@@ -37,6 +37,7 @@ class BackgroundTracingManagerImpl : public BackgroundTracingManager {

void OnRuleTriggered(const BackgroundTracingRule* triggered_rule,

StartedFinalizingCallback callback);

void AbortScenario();

+ bool HasActiveScenario() override;

// For tests

void InvalidateTriggerHandlesForTesting() override;

@@ -45,7 +46,6 @@ class BackgroundTracingManagerImpl : public BackgroundTracingManager {

CONTENT_EXPORT void SetRuleTriggeredCallbackForTesting(

const base::Closure& callback);

void FireTimerForTesting() override;

- bool HasActiveScenarioForTesting() override;

CONTENT_EXPORT bool IsTracingForTesting();

private:

« no previous file with comments | « chrome/browser/ui/tab_helpers.cc ('k') | content/browser/tracing/background_tracing_manager_impl.cc » ('j') | no next file with comments »