Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: chrome/browser/tracing/navigation_tracing.cc

Issue 1426803004: Made the NavigationTracingObserver always be active whenever background tracing is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@random_triggers
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/tracing/navigation_tracing.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tracing/navigation_tracing.h" 5 #include "chrome/browser/tracing/navigation_tracing.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/tracing/crash_service_uploader.h" 10 #include "chrome/browser/tracing/crash_service_uploader.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 scoped_ptr<content::BackgroundTracingConfig> config( 72 scoped_ptr<content::BackgroundTracingConfig> config(
73 content::BackgroundTracingConfig::FromDict(&dict)); 73 content::BackgroundTracingConfig::FromDict(&dict));
74 DCHECK(config); 74 DCHECK(config);
75 75
76 content::BackgroundTracingManager::GetInstance()->SetActiveScenario( 76 content::BackgroundTracingManager::GetInstance()->SetActiveScenario(
77 config.Pass(), base::Bind(&UploadCallback), 77 config.Pass(), base::Bind(&UploadCallback),
78 content::BackgroundTracingManager::NO_DATA_FILTERING); 78 content::BackgroundTracingManager::NO_DATA_FILTERING);
79 } 79 }
80 80
81 bool NavigationTracingObserver::IsEnabled() {
82 return content::BackgroundTracingManager::GetInstance()->HasActiveScenario();
83 }
84
81 NavigationTracingObserver::NavigationTracingObserver( 85 NavigationTracingObserver::NavigationTracingObserver(
82 content::WebContents* web_contents) 86 content::WebContents* web_contents)
83 : content::WebContentsObserver(web_contents) { 87 : content::WebContentsObserver(web_contents) {
84 if (navigation_handle == -1) { 88 if (navigation_handle == -1) {
85 navigation_handle = 89 navigation_handle =
86 content::BackgroundTracingManager::GetInstance()->RegisterTriggerType( 90 content::BackgroundTracingManager::GetInstance()->RegisterTriggerType(
87 kNavigationTracingConfig); 91 kNavigationTracingConfig);
88 } 92 }
89 } 93 }
90 94
91 NavigationTracingObserver::~NavigationTracingObserver() { 95 NavigationTracingObserver::~NavigationTracingObserver() {
92 } 96 }
93 97
94 void NavigationTracingObserver::DidStartProvisionalLoadForFrame( 98 void NavigationTracingObserver::DidStartProvisionalLoadForFrame(
95 content::RenderFrameHost* render_frame_host, 99 content::RenderFrameHost* render_frame_host,
96 const GURL& validated_url, 100 const GURL& validated_url,
97 bool is_error_page, 101 bool is_error_page,
98 bool is_iframe_srcdoc) { 102 bool is_iframe_srcdoc) {
99 if (!render_frame_host->GetParent() && !is_error_page) { 103 if (!render_frame_host->GetParent() && !is_error_page) {
100 content::BackgroundTracingManager::GetInstance()->TriggerNamedEvent( 104 content::BackgroundTracingManager::GetInstance()->TriggerNamedEvent(
101 navigation_handle, 105 navigation_handle,
102 content::BackgroundTracingManager::StartedFinalizingCallback()); 106 content::BackgroundTracingManager::StartedFinalizingCallback());
103 } 107 }
104 } 108 }
105 109
106 content::BackgroundTracingManager::TriggerHandle 110 content::BackgroundTracingManager::TriggerHandle
107 NavigationTracingObserver::navigation_handle = -1; 111 NavigationTracingObserver::navigation_handle = -1;
108 112
109 } // namespace tracing 113 } // namespace tracing
OLDNEW
« no previous file with comments | « chrome/browser/tracing/navigation_tracing.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698