Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 14267024: Devserver: have a separate ObjectStore namespace (both memcache and datastore) (Closed)

Created:
7 years, 8 months ago by not at google - send to devlin
Modified:
7 years, 8 months ago
Reviewers:
cduvall
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Devserver: have a separate ObjectStore namespace (both memcache and datastore) for each version of the server. Without this, it's impossible to safely roll back the server since the data format and/or content might have changed. This also make the _VERSION stuff moot since updating the server will give everything a new namespace. Since we only run this stuff in cronjobs there will only be a performance impact there, which doesn't really matter. BUG=167432 NOTRY=true

Patch Set 1 #

Patch Set 2 : Remove all of the _VERSION/version= stuff #

Patch Set 3 : remove presubmit check, cleanup #

Total comments: 2

Patch Set 4 : remove _CheckVersions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -177 lines) Patch
M chrome/common/extensions/PRESUBMIT.py View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_data_source.py View 1 2 chunks +1 line, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_data_source_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/api_list_data_source.py View 1 2 3 chunks +8 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_list_data_source_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/appengine_wrappers.py View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/branch_utility.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/caching_file_system.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/caching_file_system_test.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/compiled_file_system.py View 1 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/server2/compiled_file_system_test.py View 1 2 chunks +11 lines, -16 lines 0 comments Download
M chrome/common/extensions/docs/server2/example_zipper.py View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/example_zipper_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/file_system.py View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/server2/github_file_system.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/intro_data_source.py View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/object_store_creator.py View 1 1 chunk +31 lines, -15 lines 0 comments Download
M chrome/common/extensions/docs/server2/object_store_creator_test.py View 1 1 chunk +9 lines, -19 lines 0 comments Download
M chrome/common/extensions/docs/server2/offline_file_system.py View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/server2/path_canonicalizer_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/samples_data_source.py View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/server_instance.py View 1 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/sidenav_data_source.py View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/sidenav_data_source_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/subversion_file_system.py View 1 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source.py View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source_test.py View 1 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
https://codereview.chromium.org/14267024/diff/5001/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (left): https://codereview.chromium.org/14267024/diff/5001/chrome/common/extensions/docs/server2/api_list_data_source.py#oldcode17 chrome/common/extensions/docs/server2/api_list_data_source.py:17: ] devtools got deleted a while ago, cleanup https://codereview.chromium.org/14267024/diff/5001/chrome/common/extensions/docs/server2/object_store_creator.py ...
7 years, 8 months ago (2013-04-22 16:43:37 UTC) #1
cduvall
This is cool, I really like this change. lgtm
7 years, 8 months ago (2013-04-23 23:55:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/14267024/5001
7 years, 8 months ago (2013-04-24 04:20:57 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-24 04:22:10 UTC) #4
Presubmit check for 14267024-5001 failed and returned exit status 1.

INFO:root:Found 27 file(s).

ERROR:root:extensions/examples/api/downloads/download_links/icon.png had empty
content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery-ui-1.8.4.custom.min.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.valuelabels.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.navigate.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.js had
empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.client.js had
empty content
ERROR:root:extensions/examples/apps/hello-python/oauth2/clients/__init__.py had
empty content
..ERROR:root:File system is offline, cannot read
docs/templates/public/extensions/
.
----------------------------------------------------------------------
Ran 3 tests in 59.109s

OK
Running cron...
Took 52.7798240185 seconds
Rendering 234 public files...
Took 6.31759905815 seconds
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1368, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1180, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1097, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 155, in CheckChangeOnCommit
  File "<string>", line 147, in _CheckChange
NameError: global name '_CheckVersions' is not defined

Powered by Google App Engine
This is Rietveld 408576698