Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/common/extensions/PRESUBMIT.py

Issue 14267024: Devserver: have a separate ObjectStore namespace (both memcache and datastore) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove _CheckVersions Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/api_data_source.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/PRESUBMIT.py
diff --git a/chrome/common/extensions/PRESUBMIT.py b/chrome/common/extensions/PRESUBMIT.py
index d5c19898aa5dd4eeb4e807751e65c8b3a4c06e86..7841212652297d818fa5b46863456bd7af7ab26b 100644
--- a/chrome/common/extensions/PRESUBMIT.py
+++ b/chrome/common/extensions/PRESUBMIT.py
@@ -92,24 +92,6 @@ def _CheckHeadingIDs(input_api):
bad_files.append(name)
return bad_files
-def _CheckVersions(input_api, output_api, results):
- version = '_VERSION ='
- for affected_file in input_api.AffectedFiles():
- local_path = affected_file.LocalPath()
- if not fnmatch.fnmatch(local_path, '%s*' % SERVER2_PATH):
- continue
- if local_path.endswith('PRESUBMIT.py'):
- continue
- if any(version in line for line in affected_file.NewContents()):
- found = False
- for _, text in affected_file.ChangedContents():
- if version in text:
- found = True
- break
- if not found:
- results.append(output_api.PresubmitPromptWarning(
- '_VERSION of %s needs to be incremented.' % affected_file))
-
def _CheckLinks(input_api, output_api, results):
for affected_file in input_api.AffectedFiles():
name = affected_file.LocalPath()
@@ -162,7 +144,6 @@ def _CheckChange(input_api, output_api):
cwd=input_api.PresubmitLocalPath())
except input_api.subprocess.CalledProcessError:
results.append(output_api.PresubmitError('IntegrationTest failed!'))
- _CheckVersions(input_api, output_api, results)
_CheckLinks(input_api, output_api, results)
return results
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/api_data_source.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698