Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 1426533008: Make ScopedGeneric uses slightly more consistent (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M client/settings.h View 1 chunk +1 line, -1 line 0 comments Download
M client/settings.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M util/win/process_info_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M util/win/scoped_local_alloc.h View 1 chunk +6 lines, -1 line 0 comments Download
M util/win/scoped_local_alloc.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-09 14:10:12 UTC) #2
scottmg
lgtm
5 years, 1 month ago (2015-11-09 19:06:09 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-11-09 20:33:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81ece89d6aa65696347e47aa8a57fa0665f87d2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698