Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: client/settings.cc

Issue 1426533008: Make ScopedGeneric uses slightly more consistent (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « client/settings.h ('k') | util/win/process_info_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "client/settings.h" 15 #include "client/settings.h"
16 16
17 #include <limits> 17 #include <limits>
18 18
19 #include "base/logging.h" 19 #include "base/logging.h"
20 #include "base/posix/eintr_wrapper.h" 20 #include "base/posix/eintr_wrapper.h"
21 #include "util/numeric/in_range_cast.h" 21 #include "util/numeric/in_range_cast.h"
22 22
23 namespace crashpad { 23 namespace crashpad {
24 24
25 namespace internal { 25 namespace internal {
26 26
27 // static 27 // static
28 FileHandle ScopedLockedFileHandleTraits::InvalidValue() {
29 return kInvalidFileHandle;
30 }
31
32 // static
33 void ScopedLockedFileHandleTraits::Free(FileHandle handle) { 28 void ScopedLockedFileHandleTraits::Free(FileHandle handle) {
34 if (handle != kInvalidFileHandle) { 29 if (handle != kInvalidFileHandle) {
35 LoggingUnlockFile(handle); 30 LoggingUnlockFile(handle);
36 CheckedCloseFile(handle); 31 CheckedCloseFile(handle);
37 } 32 }
38 } 33 }
39 34
40 } // namespace internal 35 } // namespace internal
41 36
42 struct Settings::Data { 37 struct Settings::Data {
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 304
310 bool Settings::InitializeSettings(FileHandle handle) { 305 bool Settings::InitializeSettings(FileHandle handle) {
311 Data settings; 306 Data settings;
312 if (!settings.client_id.InitializeWithNew()) 307 if (!settings.client_id.InitializeWithNew())
313 return false; 308 return false;
314 309
315 return WriteSettings(handle, settings); 310 return WriteSettings(handle, settings);
316 } 311 }
317 312
318 } // namespace crashpad 313 } // namespace crashpad
OLDNEW
« no previous file with comments | « client/settings.h ('k') | util/win/process_info_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698