client/settings.cc - Issue 1426533008: Make ScopedGeneric uses slightly more consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/settings.cc

Issue 1426533008: Make ScopedGeneric uses slightly more consistent (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/settings.cc

diff --git a/client/settings.cc b/client/settings.cc

index 6d4640772f8b58fae393286b696277d81dee49c3..32297811805caeb37030afd9a152204110931fa0 100644

--- a/client/settings.cc

+++ b/client/settings.cc

@@ -25,11 +25,6 @@ namespace crashpad {

namespace internal {

// static

-FileHandle ScopedLockedFileHandleTraits::InvalidValue() {

- return kInvalidFileHandle;

-// static

void ScopedLockedFileHandleTraits::Free(FileHandle handle) {

if (handle != kInvalidFileHandle) {

LoggingUnlockFile(handle);

« no previous file with comments | « client/settings.h ('k') | util/win/process_info_test.cc » ('j') | no next file with comments »