test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc - Issue 1425633002: [Interpreter] Add support for loading from / storing to outer context variables.

Unified Diff: test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

Issue 1425633002: [Interpreter] Add support for loading from / storing to outer context variables. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_conditional

Patch Set: Fix interpreter-assembler-unittests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc ('k') | test/unittests/compiler/interpreter-assembler-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

diff --git a/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc b/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

index 4c8e0c043104ff8b8d12d21a93cb6f46c969f42b..40ac9274c05c4603586b4ab6cbcbd7ebdb5b5a6b 100644

--- a/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

+++ b/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

@@ -249,7 +249,8 @@ TEST_P(InstructionSelectorMemoryAccessTest, LoadWithImmediateIndex) {

TEST_P(InstructionSelectorMemoryAccessTest, StoreWithParameters) {

const MemoryAccess memacc = GetParam();

StreamBuilder m(this, kMachInt32, kMachPtr, kMachInt32, memacc.type);

- m.Store(memacc.type, m.Parameter(0), m.Parameter(1), m.Parameter(2));

+ StoreRepresentation store_rep(memacc.type, kNoWriteBarrier);

+ m.Store(store_rep, m.Parameter(0), m.Parameter(1), m.Parameter(2));

m.Return(m.Int32Constant(0));

Stream s = m.Build();

ASSERT_EQ(1U, s.size());

@@ -263,7 +264,8 @@ TEST_P(InstructionSelectorMemoryAccessTest, StoreWithImmediateBase) {

const MemoryAccess memacc = GetParam();

TRACED_FOREACH(int32_t, base, kImmediates) {

StreamBuilder m(this, kMachInt32, kMachInt32, memacc.type);

- m.Store(memacc.type, m.Int32Constant(base), m.Parameter(0), m.Parameter(1));

+ StoreRepresentation store_rep(memacc.type, kNoWriteBarrier);

+ m.Store(store_rep, m.Int32Constant(base), m.Parameter(0), m.Parameter(1));

m.Return(m.Int32Constant(0));

Stream s = m.Build();

ASSERT_EQ(1U, s.size());

@@ -284,8 +286,8 @@ TEST_P(InstructionSelectorMemoryAccessTest, StoreWithImmediateIndex) {

const MemoryAccess memacc = GetParam();

TRACED_FOREACH(int32_t, index, kImmediates) {

StreamBuilder m(this, kMachInt32, kMachPtr, memacc.type);

- m.Store(memacc.type, m.Parameter(0), m.Int32Constant(index),

- m.Parameter(1));

+ StoreRepresentation store_rep(memacc.type, kNoWriteBarrier);

+ m.Store(store_rep, m.Parameter(0), m.Int32Constant(index), m.Parameter(1));

m.Return(m.Int32Constant(0));

Stream s = m.Build();

ASSERT_EQ(1U, s.size());

@@ -319,7 +321,8 @@ class AddressingModeUnitTest : public InstructionSelectorTest {

void Run(Node* base, Node* load_index, Node* store_index,

AddressingMode mode) {

Node* load = m->Load(kMachInt32, base, load_index);

- m->Store(kMachInt32, base, store_index, load);

+ m->Store(StoreRepresentation(kMachInt32, kNoWriteBarrier), base,

+ store_index, load);

m->Return(m->Int32Constant(0));

Stream s = m->Build();

ASSERT_EQ(2U, s.size());