Issue 1425533010: Update documentation for secure networking classes. Remove certificateName parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1425533010: Update documentation for secure networking classes. Remove certificateName parameter. (Closed)

Created:
5 years, 1 month ago by Bill Hesse

Modified:
5 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update documentation for secure networking classes. Remove certificateName parameter. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/1adacaf300e0ac7eae222aa45d61ffbfe7b48383

Patch Set 2 : Change documentation for HttpServer.bind shared parameter. #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -69 lines)			Patch
M	sdk/lib/io/http.dart	View	1	7 chunks	+32 lines, -22 lines	1 comment	Download
M	sdk/lib/io/http_impl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/io/secure_server_socket.dart	View		3 chunks	+17 lines, -23 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	sdk/lib/io/socket.dart	View		2 chunks	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Søren Gjesse

lgtm https://codereview.chromium.org/1425533010/diff/20001/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/1425533010/diff/20001/sdk/lib/io/http.dart#newcode1250 sdk/lib/io/http.dart:1250: * trusted CAs from Mozilla's Firefox browser. Are ...

5 years, 1 month ago (2015-11-02 16:15:35 UTC) #3

Bill Hesse

5 years, 1 month ago (2015-11-02 16:41:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1adacaf300e0ac7eae222aa45d61ffbfe7b48383 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1425533010: Update documentation for secure networking classes. Remove certificateName parameter. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Change documentation for HttpServer.bind shared parameter. #

Messages