Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: sdk/lib/io/secure_server_socket.dart

Issue 1425533010: Update documentation for secure networking classes. Remove certificateName parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Change documentation for HttpServer.bind shared parameter. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/secure_server_socket.dart
diff --git a/sdk/lib/io/secure_server_socket.dart b/sdk/lib/io/secure_server_socket.dart
index 04ec9e0104054a57327b14c103432b1c9a11ce92..2fbc5b1224792b61f8db10365028889fc6073388 100644
--- a/sdk/lib/io/secure_server_socket.dart
+++ b/sdk/lib/io/secure_server_socket.dart
@@ -41,25 +41,25 @@ class SecureServerSocket extends Stream<SecureSocket> {
* the system.
*
* Incoming client connections are promoted to secure connections, using
- * the server certificate given by [certificateName].
+ * the server certificate and key set in [context].
*
* [address] must be given as a numeric address, not a host name.
*
* To request or require that clients authenticate by providing an SSL (TLS)
* client certificate, set the optional parameter [requestClientCertificate]
* or [requireClientCertificate] to true. Requiring a certificate implies
- * requesting a certificate, so one doesn't need to set both to true.
+ * requesting a certificate, so setting both is redundant.
* To check whether a client certificate was received, check
* SecureSocket.peerCertificate after connecting. If no certificate
* was received, the result will be null.
*
- * The optional argument [shared] specify whether additional binds
- * to the same `address`, `port` and `v6Only` combination is
- * possible from the same Dart process. If `shared` is `true` and
- * additional binds are performed, then the incoming connections
- * will be distributed between that set of
- * `SecureServerSocket`s. One way of using this is to have number of
- * isolates between which incoming connections are distributed.
+ * The optional argument [shared] specifies whether additional
+ * SecureServerSocket objects can bind to the same combination of `address`,
+ * `port` and `v6Only`. If `shared` is `true` and more `SecureServerSocket`s
+ * from this isolate or other isolates are bound to the port, then the
+ * incoming connections will be distributed among all the bound
+ * `SecureServerSocket`s. Connections can be distributed over multiple
+ * isolates this way.
*/
static Future<SecureServerSocket> bind(
address,
@@ -170,16 +170,10 @@ class RawSecureServerSocket extends Stream<RawSecureSocket> {
* the system.
*
* Incoming client connections are promoted to secure connections,
- * using the server certificate given by [certificateName].
+ * using the server certificate and key set in [context].
*
* [address] must be given as a numeric address, not a host name.
*
- * [certificateName] is the nickname or the distinguished name (DN) of
- * the certificate in the certificate database. It is looked up in the
- * NSS certificate database set by SecureSocket.setCertificateDatabase.
- * If [certificateName] contains "CN=", it is assumed to be a distinguished
- * name. Otherwise, it is looked up as a nickname.
- *
* To request or require that clients authenticate by providing an SSL (TLS)
* client certificate, set the optional parameters requestClientCertificate or
* requireClientCertificate to true. Require implies request, so one doesn't
@@ -187,13 +181,13 @@ class RawSecureServerSocket extends Stream<RawSecureSocket> {
* check SecureSocket.peerCertificate after connecting. If no certificate
* was received, the result will be null.
*
- * The optional argument [shared] specify whether additional binds
- * to the same `address`, `port` and `v6Only` combination is
- * possible from the same Dart process. If `shared` is `true` and
- * additional binds are performed, then the incoming connections
- * will be distributed between that set of
- * `RawSecureServerSocket`s. One way of using this is to have number
- * of isolates between which incoming connections are distributed.
+ * The optional argument [shared] specifies whether additional
+ * RawSecureServerSocket objects can bind to the same combination of
+ * `address`, `port` and `v6Only`. If `shared` is `true` and more
+ * `RawSecureServerSocket`s from this isolate or other isolates are bound to
+ * the port, then the incoming connections will be distributed among all the
+ * bound `RawSecureServerSocket`s. Connections can be distributed over
+ * multiple isolates this way.
*/
static Future<RawSecureServerSocket> bind(
address,

Powered by Google App Engine
This is Rietveld 408576698