Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: sdk/lib/io/secure_socket.dart

Issue 1425533010: Update documentation for secure networking classes. Remove certificateName parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Change documentation for HttpServer.bind shared parameter. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/secure_socket.dart
diff --git a/sdk/lib/io/secure_socket.dart b/sdk/lib/io/secure_socket.dart
index 5e417e56e361d509f7ee2e0aa6b4190af18bc772..cf8dec0eb80aa287d07e544611304a26d36b0c80 100644
--- a/sdk/lib/io/secure_socket.dart
+++ b/sdk/lib/io/secure_socket.dart
@@ -14,7 +14,7 @@ abstract class SecureSocket implements Socket {
external factory SecureSocket._(RawSecureSocket rawSocket);
/**
- * Constructs a new secure client socket and connect it to the given
+ * Constructs a new secure client socket and connects it to the given
* [host] on port [port]. The returned Future will complete with a
* [SecureSocket] that is connected and ready for subscription.
*
@@ -167,24 +167,24 @@ abstract class SecureSocket implements Socket {
* RawSecureSocket provides a secure (SSL or TLS) network connection.
* Client connections to a server are provided by calling
* RawSecureSocket.connect. A secure server, created with
- * RawSecureServerSocket, also returns RawSecureSocket objects representing
+ * [RawSecureServerSocket], also returns RawSecureSocket objects representing
* the server end of a secure connection.
* The certificate provided by the server is checked
* using the trusted certificates set in the SecurityContext object.
- * The default SecurityContext object contains a built-in set of trusted
+ * The default [SecurityContext] object contains a built-in set of trusted
* root certificates for well-known certificate authorities.
*/
abstract class RawSecureSocket implements RawSocket {
/**
* Constructs a new secure client socket and connect it to the given
- * host on the given port. The returned Future is completed with the
+ * host on the given port. The returned [Future] is completed with the
* RawSecureSocket when it is connected and ready for subscription.
*
- * The certificate provided by the server is checked
- * using the trusted certificates set in the SecurityContext object
- * If a certificate and key are set on the client, using useCertificateChain
- * and usePrivateKey, and the server asks for a client certificate,
- * then that client certificate is sent to the server.
+ * The certificate provided by the server is checked using the trusted
+ * certificates set in the SecurityContext object If a certificate and key are
+ * set on the client, using [SecurityContext.useCertificateChain] and
+ * [SecurityContext.usePrivateKey], and the server asks for a client
+ * certificate, then that client certificate is sent to the server.
*
* [onBadCertificate] is an optional handler for unverifiable certificates.
* The handler receives the [X509Certificate], and can inspect it and

Powered by Google App Engine
This is Rietveld 408576698