Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: mojo/services/tracing/public/interfaces/tracing.mojom

Issue 1425263003: Use TimeTicks as much as possible in startup_metric_utils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ifdef thread priority dance out on Mac per lack of support in base Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/tracing/public/interfaces/tracing.mojom
diff --git a/mojo/services/tracing/public/interfaces/tracing.mojom b/mojo/services/tracing/public/interfaces/tracing.mojom
index b702163ecf26cb6db13d7c2e8c6c2fbe9926b509..b624f81e24f9da19b3c352d8b9c21b2e80bb8332 100644
--- a/mojo/services/tracing/public/interfaces/tracing.mojom
+++ b/mojo/services/tracing/public/interfaces/tracing.mojom
@@ -31,18 +31,19 @@ interface TraceCollector {
};
// These times are used to determine startup performance metrics.
-// TODO(msw): Use TimeTicks to avoid system clock changes: crbug.com/521164
+// TODO(msw): Find a way to convert *_time metrics into TimeTicks earlier (ref:
+// https://goo.gl/vZ8dZW).
struct StartupPerformanceTimes {
// TODO(msw): Rename to match "BrowserMainEntryTimeAbsolute" metric?
int64 shell_process_creation_time;
int64 shell_main_entry_point_time;
- int64 browser_message_loop_start_time;
- int64 browser_window_display_time;
+ int64 browser_message_loop_start_ticks;
+ int64 browser_window_display_ticks;
int64 browser_open_tabs_time_delta;
// TODO(msw): Rename to avoid "web contents"?
- int64 first_web_contents_main_frame_load_time;
+ int64 first_web_contents_main_frame_load_ticks;
// TODO(msw): Rename to match "FirstWebContents.NonEmptyPaint" metric?
- int64 first_visually_non_empty_layout_time;
+ int64 first_visually_non_empty_layout_ticks;
};
// This interface accepts startup performance timing from a variety of sources.
@@ -50,11 +51,11 @@ interface StartupPerformanceDataCollector {
// These setters may be called many times, only the first time is recorded.
SetShellProcessCreationTime(int64 time);
SetShellMainEntryPointTime(int64 time);
- SetBrowserMessageLoopStartTime(int64 time);
- SetBrowserWindowDisplayTime(int64 time);
+ SetBrowserMessageLoopStartTicks(int64 ticks);
+ SetBrowserWindowDisplayTicks(int64 ticks);
SetBrowserOpenTabsTimeDelta(int64 delta);
- SetFirstWebContentsMainFrameLoadTime(int64 time);
- SetFirstVisuallyNonEmptyLayoutTime(int64 time);
+ SetFirstWebContentsMainFrameLoadTicks(int64 ticks);
+ SetFirstVisuallyNonEmptyLayoutTicks(int64 ticks);
// Get the currently available startup performance times.
GetStartupPerformanceTimes() => (StartupPerformanceTimes times);

Powered by Google App Engine
This is Rietveld 408576698