mojo/services/tracing/tracing_app.h - Issue 1425263003: Use TimeTicks as much as possible in startup_metric_utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/tracing/tracing_app.h

Issue 1425263003: Use TimeTicks as much as possible in startup_metric_utils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ifdef thread priority dance out on Mac per lack of support in base Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/startup_metric_utils/browser/startup_metric_utils.cc ('K') | « mojo/services/tracing/public/interfaces/tracing.mojom ('k') | mojo/services/tracing/tracing_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/tracing/tracing_app.h

diff --git a/mojo/services/tracing/tracing_app.h b/mojo/services/tracing/tracing_app.h

index 40cec2c2d57b35c97edc3c395a74ec7385cb2f8e..ccf7a3524721f239c18af3c8f3862e84bd455f5b 100644

--- a/mojo/services/tracing/tracing_app.h

+++ b/mojo/services/tracing/tracing_app.h

@@ -51,11 +51,11 @@ class TracingApp

// StartupPerformanceDataCollector implementation.

void SetShellProcessCreationTime(int64 time) override;

void SetShellMainEntryPointTime(int64 time) override;

- void SetBrowserMessageLoopStartTime(int64 time) override;

- void SetBrowserWindowDisplayTime(int64 time) override;

+ void SetBrowserMessageLoopStartTicks(int64 ticks) override;

+ void SetBrowserWindowDisplayTicks(int64 ticks) override;

void SetBrowserOpenTabsTimeDelta(int64 delta) override;

- void SetFirstWebContentsMainFrameLoadTime(int64 time) override;

- void SetFirstVisuallyNonEmptyLayoutTime(int64 time) override;

+ void SetFirstWebContentsMainFrameLoadTicks(int64 ticks) override;

+ void SetFirstVisuallyNonEmptyLayoutTicks(int64 ticks) override;

void GetStartupPerformanceTimes(

const GetStartupPerformanceTimesCallback& callback) override;