Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: mandoline/ui/desktop_ui/browser_window.cc

Issue 1425263003: Use TimeTicks as much as possible in startup_metric_utils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ifdef thread priority dance out on Mac per lack of support in base Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mandoline/ui/desktop_ui/browser_window.cc
diff --git a/mandoline/ui/desktop_ui/browser_window.cc b/mandoline/ui/desktop_ui/browser_window.cc
index 5a9dcaf0df69a7aae24a0948d84efa915845f48f..0d0f1f249f8fd37aa3b725082a8b6b51aef2ddbd 100644
--- a/mandoline/ui/desktop_ui/browser_window.cc
+++ b/mandoline/ui/desktop_ui/browser_window.cc
@@ -170,7 +170,7 @@ void BrowserWindow::OnEmbed(mus::Window* root) {
CHECK(!root_);
// Record when the browser window was displayed, used for performance testing.
- const base::Time display_time = base::Time::Now();
+ const base::TimeTicks display_ticks = base::TimeTicks::Now();
root_ = root;
@@ -214,7 +214,8 @@ void BrowserWindow::OnEmbed(mus::Window* root) {
LoadURL(default_url_);
// Record the time spent opening initial tabs, used for performance testing.
- const base::TimeDelta open_tabs_delta = base::Time::Now() - display_time;
+ const base::TimeDelta open_tabs_delta =
+ base::TimeTicks::Now() - display_ticks;
// Record the browser startup time metrics, used for performance testing.
static bool recorded_browser_startup_metrics = false;
@@ -225,10 +226,10 @@ void BrowserWindow::OnEmbed(mus::Window* root) {
request->url = mojo::String::From("mojo:tracing");
tracing::StartupPerformanceDataCollectorPtr collector;
app_->ConnectToService(request.Pass(), &collector);
- collector->SetBrowserWindowDisplayTime(display_time.ToInternalValue());
+ collector->SetBrowserWindowDisplayTicks(display_ticks.ToInternalValue());
collector->SetBrowserOpenTabsTimeDelta(open_tabs_delta.ToInternalValue());
- collector->SetBrowserMessageLoopStartTime(
- manager_->startup_time().ToInternalValue());
+ collector->SetBrowserMessageLoopStartTicks(
+ manager_->startup_ticks().ToInternalValue());
recorded_browser_startup_metrics = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698